Conversation
This adds more support for filtering out environment variables. OPENSSL_CONF was filtered out in a previous PR, ASPNETCORE_URLS and NUGET_PACKAGES are explicity filtered out along with it. Variables beginning with the prefixes "DOTNET_" and "CLR_" are also filtered out, with the option to allow some variables beginning with those prefixes in, like "DOTNET_ROOT".
Member
Does this hacks/workarounds motivation still apply? My review feedback: if we're filtering variables, all that gets filtered out should be printed in the runner output because it may be non-obvious to the user of the test runner that they got filtered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more support for filtering out environment variables. OPENSSL_CONF was filtered out in a previous PR, ASPNETCORE_URLS and NUGET_PACKAGES are explicity filtered out along with it. Variables beginning with the prefixes "DOTNET_" and "CLR_" are also filtered out, with the option to allow some variables beginning with those prefixes in, like "DOTNET_ROOT".
Closes #51