Skip to content

Add Simplified Chinese localization - #6518

Open
TsukasaHwan wants to merge 7 commits into
redis:mainfrom
TsukasaHwan:fe/feature/simplified-chinese-localization
Open

TsukasaHwan wants to merge 7 commits into
redis:mainfrom
TsukasaHwan:fe/feature/simplified-chinese-localization

Conversation

@TsukasaHwan

@TsukasaHwan TsukasaHwan commented Sep 21, 2026

Copy link
Copy Markdown

What

Added Simplified Chinese (zh-CN) localization support across the UI.

  • Registered zh-CN in the i18n configuration and language settings.
  • Added the Simplified Chinese locale and aligned its keys with en.json.
  • Localized the Insights trigger/panel and navigation menu labels, tooltips, and accessibility labels.
  • Updated the i18n documentation and language API example.
  • Kept new bg.json entries as English placeholders.
  • Added test coverage for selecting Simplified Chinese.

Testing

  • Targeted Jest suites: 8 passed, 32 tests passed.
  • ESLint passed for all modified UI files.
  • Prettier checks passed for the modified locale files and UI files.
  • Verified that en.json, bg.json, and zh-CN.json contain the same keys in the same order.
  • No screenshots or recordings were added because the change is focused on localization and text content.

Note

Low Risk
UI copy and locale registration only; no changes to auth, data handling, or connection logic.

Overview
Adds Simplified Chinese (zh-CN) as a shipped locale: i18n extract config, SUPPORTED_LANGUAGES, runtime resources, and a full zh-CN.json translation bundle aligned with en.json.

Several sidebar and Insights surfaces that still used hardcoded English are wired to t() (navigation help/notifications/cloud/GitHub, Insights panel tabs and trigger tooltips/ARIA). Matching keys land in en.json; bg.json gets English placeholders for the new keys. Settings language tests and Bruno PATCH /settings docs are updated for zh-CN.

Reviewed by Cursor Bugbot for commit 2624e7f. Bugbot is set up for automated code reviews on this repo. Configure here.

TsukasaHwan and others added 3 commits September 21, 2026 14:38
Add Simplified Chinese support across the UI, including locale registration,
language selection, translated locale data, and missing translations for
Insights and navigation components.
Add Simplified Chinese support across the UI, including locale registration,
language selection, translated locale data, and missing translations for
Insights and navigation components.
@TsukasaHwan
TsukasaHwan requested a review from a team as a code owner September 21, 2026 07:41
@CLAassistant

CLAassistant commented Sep 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 5120736. Configure here.

Comment thread redisinsight/ui/src/i18n/locales/zh-CN.json Outdated
Comment thread redisinsight/ui/src/i18n/locales/zh-CN.json Outdated
@valkirilov

Copy link
Copy Markdown
Member

Thanks for your effort @TsukasaHwan, and for the contribution. However, we're still not ready to accept this PR, there are a few places where we need to complete in order to have full support for i18n of all the strings in the app. Once this is done, we can start adding support for various languages.

Reference #6433

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants