Add Simplified Chinese localization - #6518
Open
TsukasaHwan wants to merge 7 commits into
Open
TsukasaHwan wants to merge 7 commits into
TsukasaHwan wants to merge 7 commits into
Conversation
Add Simplified Chinese support across the UI, including locale registration, language selection, translated locale data, and missing translations for Insights and navigation components.
Add Simplified Chinese support across the UI, including locale registration, language selection, translated locale data, and missing translations for Insights and navigation components.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
Reviewed by Cursor Bugbot for commit 5120736. Configure here.
Member
|
Thanks for your effort @TsukasaHwan, and for the contribution. However, we're still not ready to accept this PR, there are a few places where we need to complete in order to have full support for i18n of all the strings in the app. Once this is done, we can start adding support for various languages. Reference #6433 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Added Simplified Chinese (
zh-CN) localization support across the UI.zh-CNin the i18n configuration and language settings.en.json.bg.jsonentries as English placeholders.Testing
en.json,bg.json, andzh-CN.jsoncontain the same keys in the same order.Note
Low Risk
UI copy and locale registration only; no changes to auth, data handling, or connection logic.
Overview
Adds Simplified Chinese (
zh-CN) as a shipped locale: i18n extract config,SUPPORTED_LANGUAGES, runtime resources, and a fullzh-CN.jsontranslation bundle aligned withen.json.Several sidebar and Insights surfaces that still used hardcoded English are wired to
t()(navigation help/notifications/cloud/GitHub, Insights panel tabs and trigger tooltips/ARIA). Matching keys land inen.json;bg.jsongets English placeholders for the new keys. Settings language tests and BrunoPATCH /settingsdocs are updated forzh-CN.Reviewed by Cursor Bugbot for commit 2624e7f. Bugbot is set up for automated code reviews on this repo. Configure here.