[codex] Secure notary holder binding defaults#175
Draft
jeremi wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #172.
holder_binding.mode: didwithallowed_did_methods: [did:jwk].holder_binding.mode: none, and add aregistry-notary doctorwarning for those profiles.Impact
Omitting
holder_bindingnow makes direct SD-JWT VC issuance require holder material before a credential can be minted. Existing deployments that intentionally issue bearer-style credentials need to setholder_binding.mode: noneexplicitly.Validation
Passed:
cargo fmt --allcargo fmt --all -- --checkgit diff --checkcargo test -p registry-notary-core holder_bindingcargo test -p registry-notary --test doctor_cli doctor_json_warns_on_explicit_unbound_credential_profilecargo test -p registry-notary-server issued_sd_jwt_disclosure_uses_view_claim_redacted_object_valuecargo test -p registry-notary-server --test memoization_test subjects_sharing_memoized_read_produce_identical_iatcargo metadata --locked --all-features --format-version 1cargo check --locked --workspace --all-featuresAttempted but did not complete:
just ci-preflightfromproducts/notary: the script copiesproducts/notary/to a temp workspace and then runs Cargo there, but this checkout'sCargo.tomlis at the repository root, so it exits before checks withcould not find Cargo.toml.cargo clippy -p registry-notary-core -p registry-notary-server -p registry-notary --all-targets --all-features -- -D warnings: failed on existing unrelated lints inregistry-notary-core/src/config.rsandregistry-notary-server/src/api.rs(unnecessary_map_or,needless_borrow, andtoo_many_arguments).