Skip to content

Code Review #1

Description

@griffinh1

Code author: Jonathan Reibel

Code reviewer: Haeley Griffin

Date of review: 11/21/19

Issues

Formatting/legibility/style

  • The formatting and legibility on this project is good. I think more comments could be added in order to fully understand what is happening for an outside user. I think the formatting of the files is good and the code seems clean and readable.

Best practices

  • The best practice of this program is the formatting of the program itself. I believe the setup of the files and the formatting of the code is very readable and makes sense. Although the program is not currently working it is easy to still read the code and understand what is happening.

Reliability

  • The code currently is not running so I am unsure how reliable this code is. I believe though that the code will be reliable once complete because the code is being tested.

Testability

  • The code seems to be testable. The author has begun to test the code but the tests do not seem to be complete so that maybe a point to work on.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions