Skip to content

Bugfix Co2 price interpolation between 2025 and targetyear in NDC realization - #2463

Merged
fschreyer merged 5 commits into
remindmodel:developfrom
fschreyer:NpiNDC
Sep 10, 2026
Merged

fschreyer merged 5 commits into
remindmodel:developfrom
fschreyer:NpiNDC

Conversation

@fschreyer

@fschreyer fschreyer commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR

Macro could not cope with generic formulation as flagged here. Inserted interpolation from 2025 now.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:

/p/tmp/schreyer/Modeling/remind/Dev1/output/NDC_2035_Macro2025Fix_2026-09-08_10.00.13

  • Comparison of results (what changes by this PR?):

See example of carbon prices after interpolation (for run with 2035 NDC targets only):

dumpgdx AfterNDCTaxInterpolation.gdx pm_taxCO2eq "(2025|2030|2035|2040).*JPN"
2025  JPN  0.0695200632
2030  JPN  0.937153810176225
2035  JPN  1.80478755715245
2040  JPN  1.80511383974164

Note that afterwards, the 2030 carbon price is still capped. So in fulldata.gdx this look like:

dumpgdx fulldata.gdx pm_taxCO2eq "(2025|2030|2035|2040).*JPN"
2025  JPN  0.0695200632
2030  JPN  0.2933336
2035  JPN  1.80478755715245
2040  JPN  1.80478755715245

@fschreyer
fschreyer merged commit a641f5e into remindmodel:develop Sep 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants