Fix evaluation of peak budget to relevant time horizon - #2476
Merged
Merged
Conversation
…nvergence issues in pkBudg1000
Contributor
Author
|
Seems to work, see results |
tabeado
approved these changes
Sep 24, 2026
tabeado
left a comment
Contributor
There was a problem hiding this comment.
great that you figured this out, thanks Anne!
Approving, but I think it would be important for @fschreyer to agree
fschreyer
approved these changes
Sep 24, 2026
amerfort
marked this pull request as ready for review
September 24, 2026 12:15
strefler
approved these changes
Sep 24, 2026
strefler
left a comment
Contributor
There was a problem hiding this comment.
Good catch, thanks a lot!
Contributor
Author
|
@lea-hayez @RahelMA this is merged now <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This is a bug-fix: The peak-budget (maximum of cumulative emissions) was evaluated across the the entire time horizon (until 21050). But in scenarios where emissions remain at net-zero in the second half of the century, the 2150 cumulative emissions might slightly exceed the desired budget (was the case for SSP2-PkBud1000), but the 2150 cumulative emissions are outside of the control of the iterative target adjustment algorithm and caused convergence issues. issue 817. This PR constrains the relevant peak budget to the relevant time horizon (only up until 2100).
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
Runs are currently running here: /p/tmp/amerfort/remind_PB1000
Let's see if this already solves it, otherwise the issue might be overcome with hotfixes described in issue 818
This PR does not affect results, just enables model convergence in corner cases.