bug when downloading invoice schedule pdf - #1272
Open
jordividaller wants to merge 1 commit into
Open
Conversation
… a tab `window.open()` on the preview's `data:application/pdf;base64,...` content landed on about:blank: browsers block top-level navigation to `data:` URLs. Trigger a download through an `<a download>` instead, the same way PDFPreviewDefault already offers the contract document. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug when downloading invoice schedule pdf.
Note
Low Risk
Example-app-only UX fix for PDF preview; no auth, API, or production flow changes.
Overview
Fixes invoice schedule PDF preview in the contractor onboarding example so the file is downloaded with the correct filename instead of opening
preview.contentin a new browser tab.Adds a small
downloadInvoicePreviewhelper that builds a temporary<a>withhrefset to the preview data URI anddownloadset topreview.name, then triggers a click. Preview invoice on the create-invoice-schedule step now calls this helper on success and imports theContractorInvoicePreviewtype from@remoteoss/remote-flows.Reviewed by Cursor Bugbot for commit 0d24ec7. Bugbot is set up for automated code reviews on this repo. Configure here.