Support middleware clients for automatic Rust trace propagation - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Rust clients accept a plain Reqwest client, which prevents applications from installing tracing middleware once at construction. Callers otherwise have to route each request through a separate executor.
Accept
reqwest_middleware::ClientWithMiddlewareand return its request builders so every generated.send()uses the configured middleware. The README now teaches one construction-time insertion point usingreqwest-tracing, with compatible dependencies and the required application tracing setup.Validation:
moon run oasmith:checkpassed. The new Rust regression first failed because the constructor rejected the middleware client, then passed with concurrent requests built before entering their spans. It verifies distinct active traces, HTTP child spans, authentication, JSON error decoding, and streaming SSE responses.