fix: resolve all test failures in modified files\n\n- Fix ConferenceManagement.tsx: - #1122
Merged
RUKAYAT-CODER merged 1 commit intoJul 30, 2026
Conversation
…anagement.tsx: separate initialLoading from isLoading\n to keep buttons interactive during initial data fetch\n- Fix ConferenceManagement.tsx: change URL default to undefined\n to pass zod validation for empty optional URL field\n- Fix ConferenceManagement.tsx: use type=button + onClick pattern\n to avoid JSDOM form submission limitations\n- Fix ConferenceManagement.tsx: handleEdit now passes undefined\n for conferences without URLs\n- Fix ConferenceManagement.test.tsx: add waitFor for async loading,\n use fireEvent.click/submit for form triggers in tests\n- All 148 tests pass across 6 affected files
|
@temieehade-coder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…separate initialLoading from isLoading\n to keep buttons interactive during initial data fetch\n- Fix ConferenceManagement.tsx: change URL default to undefined\n to pass zod validation for empty optional URL field\n- Fix ConferenceManagement.tsx: use type=button + onClick pattern\n to avoid JSDOM form submission limitations\n- Fix ConferenceManagement.tsx: handleEdit now passes undefined\n for conferences without URLs\n- Fix ConferenceManagement.test.tsx: add waitFor for async loading,\n use fireEvent.click/submit for form triggers in tests\n- All 148 tests pass across 6 affected files
Closes #912