-
Notifications
You must be signed in to change notification settings - Fork 9
SDK-613: upgrade Next.js examples to 16.3.4 and add example test coverage #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devtools-agent
wants to merge
5
commits into
main
Choose a base branch
from
aicd-bot/sdk-613-rollbar-react-upgrade-nextjs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f0231b1
SDK-613: upgrade Next.js examples to 15.5.25 and add test coverage
0487fe8
SDK-613: move the Next.js examples to 16.3.4 and drop node 18 from CI
14725e3
SDK-613: fix npm ci in the Next.js examples (yalc sig in lockfile)
6c2372d
SDK-613: load package.json in the rollup config without import assert…
3277276
SDK-613: make the build matrix fail the run, and swap node 21 for 24
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import nextCoreWebVitals from 'eslint-config-next/core-web-vitals'; | ||
|
|
||
| // Next 16 removed `next lint`, so ESLint runs directly against this flat | ||
| // config. `eslint-config-next/core-web-vitals` already brings the TypeScript | ||
| // setup and the `.next`/`out`/`build` ignores with it. | ||
| /** @type {import('eslint').Linter.Config[]} */ | ||
| const config = [...nextCoreWebVitals]; | ||
|
|
||
| export default config; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| const nextJest = require('next/jest'); | ||
|
|
||
| const createJestConfig = nextJest({ dir: './' }); | ||
|
|
||
| /** @type {import('jest').Config} */ | ||
| const jestConfig = { | ||
| setupFilesAfterEnv: ['<rootDir>/jest.setup.ts'], | ||
| testEnvironment: 'jest-environment-jsdom', | ||
| testMatch: ['<rootDir>/src/__tests__/**/*.test.tsx'], | ||
| }; | ||
|
|
||
| module.exports = createJestConfig(jestConfig); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| import '@testing-library/jest-dom'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,13 @@ | ||
| import { fileURLToPath } from 'url'; | ||
| import path from 'path'; | ||
|
|
||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| /** @type {import('next').NextConfig} */ | ||
| const nextConfig = {}; | ||
| const nextConfig = { | ||
| // This example lives inside the @rollbar/react repo, so Next.js would | ||
| // otherwise infer the repo root as the workspace root. | ||
| outputFileTracingRoot: __dirname, | ||
| }; | ||
|
|
||
| export default nextConfig; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.