Skip to content

[ci] Add minimal asan build#22618

Open
silverweed wants to merge 1 commit into
root-project:masterfrom
silverweed:ci_asan
Open

[ci] Add minimal asan build#22618
silverweed wants to merge 1 commit into
root-project:masterfrom
silverweed:ci_asan

Conversation

@silverweed

@silverweed silverweed commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Using the alma10 image.

IMPORTANT: asan currently only works with gcc (or at least, that was the case on my machine).

@silverweed silverweed requested a review from jblomer June 15, 2026 15:18
@silverweed silverweed self-assigned this Jun 15, 2026
@silverweed silverweed requested a review from dpiparo as a code owner June 15, 2026 15:18
@github-actions

Copy link
Copy Markdown

Test Results

    18 files      18 suites   2d 21h 56m 33s ⏱️
 3 846 tests  3 846 ✅ 0 💤 0 ❌
62 838 runs  62 838 ✅ 0 💤 0 ❌

Results for commit 0eb641f.

@dpiparo

dpiparo commented Jun 15, 2026

Copy link
Copy Markdown
Member

this is a great initiative. To optimise, one could even turn off all other builds while in the PR with a specific commit, so that only asan can be tested, the necessary fixes added, and then all other builds re-added before merging

@dpiparo dpiparo added the clean build Ask CI to do non-incremental build on PR label Jun 15, 2026
@dpiparo dpiparo closed this Jun 15, 2026
@dpiparo dpiparo reopened this Jun 15, 2026

@ferdymercury ferdymercury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you port the changes from https://github.com/root-project/root/pull/19636/changes into here?
The documentation fix for asan build option and portentially the Halton error flag to get s full overview at once
Thks!

platform_config: alma10
is_special: true
property: "asan"
overrides: ["asan=ON", "minimal=ON"]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
overrides: ["asan=ON", "minimal=ON"]
overrides: ["asan=ON", "minimal=ON, "CMAKE_BUILD_TYPE=Debug"]

Could help in debugging

overrides: ["CMAKE_CXX_STANDARD=20"]
# Asan build
- image: alma10
platform_config: alma10

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If remember correctly the correct way to actually get a minimal build is:

Suggested change
platform_config: alma10
platform_config: alma10-minimal

Otherwise the other options just get added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants