Add RNTuple benchmark for ATLAS file - #170
Merged
Merged
Conversation
Contributor
Author
|
@oshadura Can you also review this PR? |
oshadura
self-requested a review
November 13, 2020 12:40
The original implementation built the RNTuple model by hand from the TTree branches, using low-level RField interfaces that no longer exist in current ROOT. ROOT has since gained RNTupleImporter, which does this conversion generically, so use it instead. Like gen_h1, the tool is now also a no-op if the output file already exists.
The RNTuple classes moved out of the ROOT::Experimental namespace. Also remove the many unused includes and link gen_atlas against the libraries it actually needs.
The input file is about 1.9 GB, so converting it once per compression algorithm dominates the setup time of the benchmark. Keep zstd (the RNTuple default), lzma (the strongest) and uncompressed as the extremes, and drop zlib and lz4.
guitargeek
force-pushed
the
atlas-rntuple
branch
from
September 3, 2026 20:24
83699a6 to
56c6cfe
Compare
guitargeek
approved these changes
Sep 3, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for adding this nice benchmark!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RNTupleATLASBenchmarks.cxxandgen_atlas.cxx)RNTupleAnalysisBenchmarks->RNTupleH1Benchmarks.