[Lilit summer student project] Add memory measurements to interpreted PyROOT - #190
Closed
oshadura wants to merge 3 commits into
Closed
[Lilit summer student project] Add memory measurements to interpreted PyROOT#190oshadura wants to merge 3 commits into
oshadura wants to merge 3 commits into
Conversation
Improve memory measurements for ROOT interpreter benchmark
Contributor
|
Thank you @oshadura and Lilit for this work, and apologies that it took so long to get back to it! The problem this PR tackled was very real. The memory measurements were the most fragile part of these benchmarks, and the idea of centralizing them in a shared So I'm closing this PR as superseded by #307. |
guitargeek
added a commit
that referenced
this pull request
Sep 3, 2026
RB::RunCommandMeasuringRss() runs a command like std::system() and additionally reports the maximum resident set size of the child process tree via wait4(). This is the same value that "/usr/bin/time -v" reports as "Maximum resident set size", but without depending on an external time binary, temporary files or output parsing. This supersedes the approach of PR #190, which kept shelling out to the time binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reincarnation of #95