Parametrize RDataFrame snapshot benchmarks over compression levels - #308
Merged
guitargeek merged 1 commit intoSep 3, 2026
Merged
Conversation
Each compression algorithm is now benchmarked at levels 1, 6 and 9 instead of a single hardcoded level, and the benchmarks report the compressed file size and the throughput of uncompressed input bytes. The benchmarked dataset is also made big enough for the compression to dominate over the fixed snapshot overheads (10 million doubles instead of 100 thousand). The input data is generated only once, so that unlike before, the random number generation does not contribute to the measured time. The output file is now written to RB_TEMP_FS and removed afterwards. This implements the improvements proposed for these benchmarks in PR root-project#225 on top of the current state of the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each compression algorithm is now benchmarked at levels 1, 6 and 9 instead of a single hardcoded level, and the benchmarks report the compressed file size and the throughput of uncompressed input bytes.
The benchmarked dataset is also made big enough for the compression to dominate over the fixed snapshot overheads (10 million doubles instead of 100 thousand). The input data is generated only once, so that unlike before, the random number generation does not contribute to the measured time. The output file is now written to RB_TEMP_FS and removed afterwards.
This implements the improvements proposed for these benchmarks in PR #225 on top of the current state of the repository.