Stop a resize from re-counting a deep-link arrival - #129
Merged
Conversation
Enabling analytics on deep links in #128 made every window resize fire a second commandSent event. xterm clears its buffer on resize, so resizeListener reruns the deep link to redraw the output — that is the same visit, not a new arrival. Caught it on production: one load of /portfolio/chargelab/ had already logged two events. It would have inflated exactly the numbers the tracking was added to produce, and worst on mobile, where showing and hiding the address bar fires resize. The replay path now passes trackAnalytics: false, matching the history replay immediately below it, which calls term.command directly for the same reason. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #128, which started tracking deep-link arrivals.
The bug
xterm clears its buffer on resize, so
resizeListenerrerunsrunDeepLink()to redraw the output. With analytics enabled that fires a secondcommandSentevent for the same visit.Caught it on production right after the deploy — a single load of
/portfolio/chargelab/had already logged two events:[{"event":"commandSent","command":"tldr","args":"chargelab","gtm.uniqueEventId":5}, {"event":"commandSent","command":"tldr","args":"chargelab","gtm.uniqueEventId":11}]It would have inflated exactly the numbers the tracking was added to produce, and worst on mobile, where showing and hiding the address bar fires
resize.The fix
runDeepLink({ replay: true })from the resize path, which setstrackAnalytics: false. That matches the history replay immediately below it, which callsterm.commanddirectly rather thanexecuteCommandLinefor the same reason — redrawing is not re-running.Test plan
npm test— 95/95, with a new test asserting the replay path does not count🤖 Generated with Claude Code