Add the swag command (#65), and catch the docs up to the mirror removal - #132
Merged
Conversation
It still documented the static mirror as the crawlability story — the URL list, the <noscript> block, "regenerates that company's page" — all of which #128 deleted. Replaces that section with how it actually works now: fragment addressing, the redirect map, and the visually-hidden block, plus why the mirror went away and what it cost. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Opens https://rootvc.creator-spring.com, listed in help and the README alongside the other link commands. Tab completion picks it up from the commands object with no extra wiring. Also drops a stale comment above `www` that still described the static mirror it used to point at, left behind when the body was rewritten in #128. Originally proposed in #65 in September 2022. The patch no longer applied — commands.js, help.js and the README have all moved underneath it — but the store is still live and still Root's, so the change is reapplied here rather than asking for a four-year-old branch to be rebased. Co-Authored-By: unkrich <unkrich@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
3 tasks
ledwards
added a commit
that referenced
this pull request
Aug 13, 2026
#134 dropped `swag` from config/commands.js while help.js and the README kept advertising it, so `help` listed a command that did nothing. My fault: I had edits to commands.js spread across two working trees and consolidated them by copying one file over the other, which silently reverted the two changes #132 had made to it — the command itself and a stale comment above `www`. Both are restored. The new test is the more useful half: nothing linked config/help.js to config/commands.js, so help could advertise a command that did not exist and no test would notice. It now walks every %command% in help.js and asserts a matching function exists. Verified the test fails with the exact diagnostic (expected [ 'swag' ] to deeply equal []) when the command is removed again. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 task
ledwards
added a commit
that referenced
this pull request
Aug 13, 2026
Removed from commands.js, help.js and the README together — the help/commands sync test added in #135 requires that, which is the point of it. Reverts only the command from #132; the README's crawlability rewrite in that PR stays. To bring it back, restore the three lines: config/commands.js swag: function () { term.openURL("https://rootvc.creator-spring.com"); } config/help.js "%swag%": "rootvc store", README.md - swag: rootvc store Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things.
swag(reviving #65)@unkrich proposed a
swagcommand in September 2022. The patch no longer applies —config/commands.js,config/help.jsand the README have all moved underneath it in four years — but the store at https://rootvc.creator-spring.com is still live and still Root's, so I reapplied it rather than asking for a rebase of a branch that old. Credited to them in the commit.Six lines: the command, a help entry, a README line. Tab completion picks it up from the
commandsobject with no extra wiring.README was stale after #128
It still described the static mirror as the crawlability story — the list of
/about/,/team/<slug>/URLs, the<noscript>block, "regenerates that company's page." All of that was deleted yesterday. Replaced with how it actually works now: fragment addressing, the redirect map, the.visually-hiddenblock, plus why the mirror went away and what it traded off.Also drops a stale comment above
wwwthat still claimed it points at the mirror, contradicting the comment inside the function.Test plan
npm test— 100/100npm run build, serveddist/, rancommands.swag()in the terminal: printsOpening https://rootvc.creator-spring.comand opens it;%swag%is in help;swagis in the tab-completion key setCloses #65.
🤖 Generated with Claude Code