add support for reentrant callback group to EventsCBGExecutor#3178
Open
armaho wants to merge 2 commits into
Open
add support for reentrant callback group to EventsCBGExecutor#3178armaho wants to merge 2 commits into
armaho wants to merge 2 commits into
Conversation
Signed-off-by: Arman Hosseini <armahosseini878787@gmail.com>
skyegalaxy
requested review from
jmachowinski and
skyegalaxy
and removed request for
jmachowinski
skyegalaxy
approved these changes
Jun 18, 2026
skyegalaxy
left a comment
skyegalaxy
left a comment
Member
There was a problem hiding this comment.
lgtm with green CI. will let @jmachowinski take a pass as well
| { | ||
| ready_callback_groups.erase(it); | ||
| } | ||
| return CBGScheduler::ExecutableEntityWithInfo{ |
Member
There was a problem hiding this comment.
note to self to remove C++20 initialization when backporting this to Jazzy and Kilted specifically
Member
|
actually @armaho can you add a test which exercises the reentrant path like we discussed at the client library WG meeting? |
Author
|
Sure let me see how to test it. |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
…er EventCBGExecutor Signed-off-by: Arman Hosseini <armahosseini878787@gmail.com>
armaho
force-pushed
the
events_cbg_executor_reentrant
branch
from
554512d to
855d1b2
Compare
Author
|
I just added a test covering the reentrant callback group behavior. Could you take another look when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3175
Is this user-facing behavior change?
Did you use Generative AI?
No
Additional Information