chore: bump github.com/maximhq/bifrost/core from 1.7.0 to 1.7.13 in /authbridge/authlib - #771
Conversation
|
@dependabot rebase |
c7b34d9 to
d854b07
Compare
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Dependency updates that raise a module's minimum Go version fail the
Go CI (authlib) job. That job is the only one which reads go.work --
the cmd/* matrix and dependabot-tidy both set GOWORK=off -- so with
go.work pinned at 1.26.4 any module requiring >= 1.26.5 errors:
go: module . listed in go.work file requires go >= 1.26.5,
but go.work lists go 1.26.4
and it cascades to every module in the workspace, making the failure
look broader than the one dependency that caused it.
Dependabot only edits the directory it is updating, so it can never
fix go.work itself; the failure recurs on every toolchain-raising
bump. Currently blocking #771 (bifrost/core 1.7.0 -> 1.7.13).
Modules stay at go 1.26.4. go.work only needs to be >= the highest
module directive, so raising it alone is sufficient and stays valid
once modules move to 1.26.5. The authlib job leaves GOTOOLCHAIN at
its default (auto), so it fetches the newer toolchain as needed.
Signed-off-by: Hai Huang <huang195@gmail.com>
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Dependency updates that raise a module's minimum Go version fail the
Go CI (authlib) job. That job is the only one which reads go.work --
the cmd/* matrix and dependabot-tidy both set GOWORK=off -- so with
go.work pinned at 1.26.4 any module requiring >= 1.26.5 errors:
go: module . listed in go.work file requires go >= 1.26.5,
but go.work lists go 1.26.4
and it cascades to every module in the workspace, making the failure
look broader than the one dependency that caused it.
Dependabot only edits the directory it is updating, so it can never
fix go.work itself; the failure recurs on every toolchain-raising
bump. Currently blocking #771 (bifrost/core 1.7.0 -> 1.7.13).
Modules stay at go 1.26.4. go.work only needs to be >= the highest
module directive, so raising it alone is sufficient and stays valid
once modules move to 1.26.5. The authlib job leaves GOTOOLCHAIN at
its default (auto), so it fetches the newer toolchain as needed.
Signed-off-by: Hai Huang <huang195@gmail.com>
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Bumping go.work alone does not work, and the reason is worth recording: actions/setup-go exports GOTOOLCHAIN=local itself and installs the version named by go-version-file (authbridge/authlib/go.mod). A toolchain pinned at 1.26.4 and forbidden from upgrading can never satisfy a go.work that asks for 1.26.5: go: ../go.work requires go >= 1.26.5 (running go 1.26.4; GOTOOLCHAIN=local) So the module directives have to move together with go.work: authlib's is what selects the CI toolchain, and every module that replaces authlib must not declare an older Go than authlib does. All seven workspace modules go to 1.26.5 in one step. This is not speculative -- #771 (bifrost/core 1.7.0 -> 1.7.13) already raises four of them, and Dependabot cannot touch go.work, so the split would recur on every toolchain-raising bump. Doing it deliberately keeps GOTOOLCHAIN=local hermetic and makes #771 a clean rebase. Checked: the CI matrix covers only proxy and envoy, both of which read their own go.mod with GOWORK=off; dependabot-tidy reads the same authlib/go.mod and follows automatically; the cmd Dockerfiles use golang:1.26-alpine, and 1.26.7 is released. Signed-off-by: Hai Huang <huang195@gmail.com> Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
|
Not approving yet — this is blocked on a workspace file Dependabot cannot reach, and the fix is now open as #796. The failure is not in the bifrost bump itself. Raising the module Go directives to 1.26.5 leaves #796 raises Once #796 merges, rebase this and the Assisted-By: Claude Code |
|
@dependabot rebase |
805611c to
65f0d4e
Compare
9d9f193 to
21667e7
Compare
Bumps [github.com/maximhq/bifrost/core](https://github.com/maximhq/bifrost) from 1.7.0 to 1.7.13. - [Release notes](https://github.com/maximhq/bifrost/releases) - [Changelog](https://github.com/maximhq/bifrost/blob/dev/docs/release-cadence.mdx) - [Commits](maximhq/bifrost@core/v1.7.0...core/v1.7.13) --- updated-dependencies: - dependency-name: github.com/maximhq/bifrost/core dependency-version: 1.7.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
ba0ba82 to
e362638
Compare
Auto-tidied by dependabot-tidy workflow to keep cmd/* go.sum files in sync with authlib after a Dependabot bump. Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
huang195
left a comment
There was a problem hiding this comment.
Approving now that #796 has landed — this was the one I held back while it was red.
Confirmed unblocked. The failure was never in the bifrost bump: raising the module Go directives to 1.26.5 left authbridge/go.work at 1.26.4, and Go CI (authlib) is the only job that reads go.work, so it errored about four modules at once. #796 raised go.work and all seven module directives together, and the go 1.26.5 lines have correspondingly vanished from this diff — they are no-ops now. 20 checks: 18 pass, 2 skipping (Spellcheck, tidy), 0 fail.
Verified the diff before approving, because #767 demonstrated that a Dependabot rebase can silently retarget a PR — there, 1.5.1 became 1.6.0 while an existing approval carried over, and it merged into an unsatisfiable requirements.txt. Checked here:
- Title still says 1.7.13, and the diff agrees. The
build(deps):→chore: bumpprefix change is Dependabot's newer title format, not a retarget. - Every changed
go.modline accounted for:maximhq/bifrost/core1.7.0 → 1.7.13 (direct in authlib, indirect in envoy/proxy) andbuger/jsonparser1.1.2 → 1.2.0 (indirect, pulled in transitively). Nothing else.
One observation, not blocking: the tidy job reports skipping on this PR, so dependabot-tidy did not run here. Not a problem in itself — Dependabot regenerated the go.sum files during its own rebase, and Go CI passes for all three affected modules — but worth a look at why the job's actor guard did not fire, given that workflow was just reworked in #789/#792.
Assisted-By: Claude Code
Bumps github.com/maximhq/bifrost/core from 1.7.0 to 1.7.13.
Release notes
Sourced from github.com/maximhq/bifrost/core's releases.
... (truncated)
Commits
169647creasoning fix (#6292)0c60a9bcore version cut (#6291)e06b324gemini tool call fixes (#6280)01df4affixes params sequence in chat completions (#6235) (#6274)5e59157file/image embedding flow fixes (#6239) (#6273)53c8849feat(gemini): support server-side toolCall/toolResponse parts with thoughtSig...3ff8ef4fix: bedrock files handling in inference (#5947) (#6271)4fa86d0reverting back the comment for new tags to burst cachec3386f6table name change0a8a38cUpdate changelog with new features and fixes