fix(authbridge): Bump langchain-core to 1.6.0 to unbreak requirements.txt - #799
Merged
Conversation
….txt
authbridge/requirements.txt is currently unsatisfiable on main:
langchain-core==1.5.5
langchain-openai==1.6.0 # requires langchain-core>=1.6.0,<2.0.0
$ pip install --dry-run 'langchain-openai==1.6.0' 'langchain-core==1.5.5'
ERROR: Cannot install langchain-core==1.5.5 and langchain-openai==1.6.0
because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible
How it got here: #769 pinned langchain-core to 1.5.5, and #767 was opened
against langchain-openai 1.5.1 (which needs core >= 1.5.4, satisfied). A
rebase of #767 silently retargeted it to 1.6.0, which needs core >= 1.6.0,
and it merged with an approval that predated the retarget --
dismiss_stale_reviews is false, so the approval carried over.
Nothing caught it: Python Tests completes in 12s and never installs
requirements.txt, and main has no required status checks.
1.6.0 is the current langchain-core release. Verified this resolves, and
verified it is safe to land alone -- tested against langgraph 1.2.9 (main's
pin today) and 1.2.11 (the target of open PR #765); both resolve.
Signed-off-by: Hai Huang <huang195@gmail.com>
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
evaline-ju
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently brokenauthbridge/requirements.txtonmaincannot be resolved:Reproduced rather than inferred from metadata:
Fix
langchain-core==1.5.5→1.6.0. One line.1.6.0 is the current release, so this is not a leapfrog. Verified two ways:
So this is safe to land on its own and does not need bundling with #765, in
either merge order.
How it happened
Worth recording, because the failure mode is repeatable:
langchain-coreto 1.5.5.langchain-openai1.5.1, which requireslangchain-core>=1.5.4— compatible, and reviewed on that basis.langchain-core>=1.6.0. Title and diff both changed.dismiss_stale_reviewsisfalse, so the approval granted for 1.5.1carried over onto 1.6.0 untouched, and chore: bump langchain-openai from 1.3.5 to 1.6.0 #767 merged looking fully green.
Why no check caught it
Python Testsnever installsauthbridge/requirements.txt— it finishesin ~12s, so nothing validates that these pins resolve together.
mainhas no required status checks, so an approval alone is sufficientto merge.
Two follow-ups worth considering, both outside this PR:
requirements.txt(pip install --dry-run -rwould be enough, and fast).
dismiss_stale_reviews, so a rebase that changes the proposedversion also drops the approval that was granted for the old one.
Assisted-By: Claude Code