Remove unused xpath function text() and processing-instruction()#327
Merged
Conversation
Functions must return nodeset or a primitive value. Functions::text() returning an array of string is a bug to be fixed. Although, `text()` in xpath is resolved as `[:child, :text]`, it's not a function, so Functions::text is unused.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes the Functions::text helper from REXML’s functions module, reducing the set of available XPath-related functions.
Changes:
- Removed the
Functions::textmethod fromlib/rexml/functions.rb.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
38
to
42
| def Functions::context=(value); @@context = value; end | ||
|
|
||
| def Functions::text( ) | ||
| if @@context[:node].node_type == :element | ||
| @@context[:node].find_all{|n| n.node_type == :text}.collect{|n| n.value} | ||
| elsif @@context[:node].node_type == :text | ||
| @@context[:node].value | ||
| else | ||
| false | ||
| end | ||
| end | ||
|
|
||
| # Returns the last node of the given list of nodes. | ||
| def Functions::last( ) | ||
| @@context[:size] |
tompng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #326
Functions must return nodeset or a primitive value. Functions::text() returning an array of string is a bug to be fixed. Although,
text()in xpath is resolved as[:child, :text], it's not a function, so Functions::text is unused.Also removes
Functions::processing_instruction. These are node-test, not functions.