Skip to content

verify: enable running from any directory#628

Open
RuslanProgrammer wants to merge 1 commit into
rust-bitcoin:masterfrom
RuslanProgrammer:run-verify-from-anywhere
Open

verify: enable running from any directory#628
RuslanProgrammer wants to merge 1 commit into
rust-bitcoin:masterfrom
RuslanProgrammer:run-verify-from-anywhere

Conversation

@RuslanProgrammer

Copy link
Copy Markdown
Contributor

Fixes: #627

Use absolute paths from the crate root (from CARGO_MANIFEST_DIR) instead of relative to the current working directory.

@jamillambert jamillambert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 696bd0b

I'm not sure the new paths module is necessary, but I guess it's possibly better.

Thanks for the fix.

@tcharding tcharding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 696bd0b

@tcharding

Copy link
Copy Markdown
Member

I like it! Wraps all this up in one place, easy to see at a glance instead of grepping for.

@apoelstra

Copy link
Copy Markdown
Member

696bd0b needs rebase

@RuslanProgrammer RuslanProgrammer force-pushed the run-verify-from-anywhere branch from 696bd0b to 6811a51 Compare June 17, 2026 06:30
@RuslanProgrammer

Copy link
Copy Markdown
Contributor Author

I don't think the pipeline failed because of these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verify fails unless run from a verify directory

4 participants