Fix accuracy test with new cargo build layout - #767
Merged
Conversation
This fixes the test on nightly rust. Also remove unneeded `dbginfo = "collapsible"` because `collapse_debuginfo` is stable in our MSRV. This allows the test to run on stable rust again. Also use DLL_PREFIX and DLL_SUFFIX from std::env::consts while here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the test on nightly rust.
Also remove unneeded
dbginfo = "collapsible"becausecollapse_debuginfois stable for our MSRV. This allows the test to run on stable rust again.Also use DLL_PREFIX and DLL_SUFFIX from std::env::consts while here.
Not an ideal fix, but the only environment variable I found was CARGO_CDYLIB_FILE_DYLIB_DEP_dylib_dep with a Cargo.toml change and -Z bindeps.