Skip to content

fix: range pattern inside a parenthesis parsed as tuple pattern - #23242

Merged
A4-Tacks merged 1 commit into
rust-lang:masterfrom
dfireBird:push-vrtuqvnutkrn
Aug 28, 2026
Merged

fix: range pattern inside a parenthesis parsed as tuple pattern#23242
A4-Tacks merged 1 commit into
rust-lang:masterfrom
dfireBird:push-vrtuqvnutkrn

Conversation

@dfireBird

@dfireBird dfireBird commented Aug 26, 2026

Copy link
Copy Markdown
Member

Fixes #22985

Let me know if we want to split up the expression.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2026
Comment thread crates/parser/src/tests/top_entries.rs Outdated
Comment thread crates/parser/src/grammar/patterns.rs Outdated
// (..1) => (),
// (..=3) => (),
// (..2 | 4) => (),
// }

@A4-Tacks A4-Tacks Aug 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get a clean patch by inserting this match before the original match instead of after it

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@A4-Tacks
A4-Tacks enabled auto-merge August 28, 2026 04:09
@A4-Tacks
A4-Tacks added this pull request to the merge queue Aug 28, 2026
Merged via the queue into rust-lang:master with commit cca4dd2 Aug 28, 2026
18 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2026
@dfireBird
dfireBird deleted the push-vrtuqvnutkrn branch August 28, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FP expected i32, found ({unknown},), match on const, pattern

3 participants