new lint: use_crate_prefix_for_self_imports by lengyijun · Pull Request #13662 · rust-lang/rust-clippy

lengyijun · 2024-11-07T11:04:07Z

View all comments

changelog: [use_crate_prefix_for_self_imports]: new lint

fix #13645

Only check main.rs and lib.rs

Known problem

Duplicate warning

TODO

rm tests/ui/use_crate_prefix_for_self_imports.rs
squash commits

Question

Although pass all tests, but if copy lintcheck to /tmp, clippy will report two warnings (expected)

warning: this import is not clear
  --> src/main.rs:42:5
   |
42 | use input::read_crates;
   |     ^^^^^ help: prefix with `crate::`: `crate::input`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_crate_prefix_for_self_imports
   = note: `#[warn(clippy::use_crate_prefix_for_self_imports)]` on by default

warning: this import is not clear
  --> src/main.rs:43:5
   |
43 | use output::{ClippyCheckOutput, ClippyWarning, RustcIce};
   |     ^^^^^^ help: prefix with `crate::`: `crate::output`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_crate_prefix_for_self_imports

rustbot · 2024-11-07T11:04:13Z

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

llogiq · 2025-01-10T17:26:59Z

So, as you know we discussed this on zulip a while ago. The upshot is that we have two acceptable options:

Put the lint in the nursery group and improve it until we deem it ready for style
Add more checks to the lint to reduce the number of warnings that aren't too helpful. For example, if we have the respective mod near the use (where near could be measured in line number differences or in no other items but mods and uses in between), we could avoid linting, as the reader of the code will know that the item comes from the mod specified nearby (this could be done by walking the sibling items until a non-mod-or-use item is found).

Do you intend to continue working on this?

llogiq · 2025-01-25T10:42:28Z

@rustbot author

lengyijun · 2025-01-30T06:00:24Z

Don't lint if mod and use in the same block

lengyijun · 2025-01-31T01:16:16Z

The problem of lintcheck still exists

llogiq · 2025-02-02T20:07:26Z

What does that mean?

lengyijun · 2025-02-03T01:06:41Z

Although pass all tests, but if copy lintcheck to /tmp, clippy will report two warnings (expected)

warning: this import is not clear
  --> src/main.rs:42:5
   |
42 | use input::read_crates;
   |     ^^^^^ help: prefix with `crate::`: `crate::input`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_crate_prefix_for_self_imports
   = note: `#[warn(clippy::use_crate_prefix_for_self_imports)]` on by default

warning: this import is not clear
  --> src/main.rs:43:5
   |
43 | use output::{ClippyCheckOutput, ClippyWarning, RustcIce};
   |     ^^^^^^ help: prefix with `crate::`: `crate::output`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_crate_prefix_for_self_imports

rustbot · 2026-09-03T11:25:57Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

github-actions · 2026-09-03T12:53:37Z

Lintcheck changes for 1554268

Lint	Added	Removed	Changed
`clippy::use_crate_prefix_for_self_imports`	128	0	0

This comment will be updated if you push new changes

lengyijun · 2026-09-03T13:07:15Z

@llogiq @Jarcho #13662 (comment) The problem still exists

Jarcho · 2026-09-04T00:59:56Z

+        let FileName::Real(p) = cx.sess().source_map().span_to_filename(item.span) else {
+            self.clear();
+            return;
+        };
+        let Some(p) = p.local_path() else {
+            return;
+        };
+        let Some(file_name) = p.file_name() else {
+            self.clear();
+            return;
+        };
+        // only check `main.rs` and `lib.rs`
+        if !(file_name == "main.rs" || file_name == "lib.rs") {
+            return;
+        }


The first symbol in the path is either a crate or a name in the current scope. For items in the current scope they're defined at either the module level or the statement level. All those at the module level can always use the self:: prefix.

View changes since the review

Jarcho · 2026-09-04T01:00:56Z

@rustbot label lint-nominated

rustbot · 2026-09-04T01:01:01Z

This lint has been nominated for inclusion.

A FCP topic has been created on Zulip.

rustbot · 2026-10-11T14:48:14Z

☔ The latest upstream changes (possibly #13598) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot assigned llogiq Nov 7, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 7, 2024

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch from 2a70749 to bfc0849 Compare November 7, 2024 11:40

lengyijun changed the title ~~use crate prefix for self imports~~ new lint use_crate_prefix_for_self_imports Nov 7, 2024

lengyijun changed the title ~~new lint use_crate_prefix_for_self_imports~~ new lint: use_crate_prefix_for_self_imports Nov 7, 2024

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch 5 times, most recently from f74a6bc to 6a0c669 Compare November 8, 2024 04:46

llogiq reviewed Nov 8, 2024

View reviewed changes

Comment thread clippy_lints/src/use_crate_prefix_for_self_imports.rs Outdated

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch from 6a0c669 to 7633f16 Compare November 13, 2024 03:26

rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 25, 2025

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch from 7633f16 to 5817b6f Compare January 27, 2025 10:20

llogiq reviewed Jan 27, 2025

View reviewed changes

Comment thread tests/ui/use_crate_prefix_for_self_imports.rs Outdated

llogiq reviewed Jan 28, 2025

View reviewed changes

Comment thread tests/ui-cargo/use_crate_prefix_for_self_imports/pass_sibling_comment/src/main.rs

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch 5 times, most recently from 840f04d to 9e1dbdc Compare January 30, 2025 04:22

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch from a500545 to a3f5529 Compare January 31, 2025 01:01

lengyijun added 14 commits September 3, 2026 18:22

no unwrap

b912a19

style => nursery

5af8dd1

fix tests

e93c097

fix after toolchain update

9dcf79a

no check_attribute

c274d2b

fmt

90a1ddc

2024

b4550f4

typo

7a6f415

wip

fe2a00e

wip

71aeb17

wip

9b91ec5

wip

63871c0

uitest

03352f4

cargo uitest: pass

47adcca

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch from fcf45ca to 410d275 Compare September 3, 2026 11:25

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch 3 times, most recently from 4142dfa to 20a5fb6 Compare September 3, 2026 12:39

lengyijun added 2 commits September 3, 2026 20:43

wip

7d1aef6

wip

1554268

lengyijun force-pushed the last_use_crate_prefix_for_self_imports branch from 20a5fb6 to 1554268 Compare September 3, 2026 12:44

Jarcho reviewed Sep 4, 2026

View reviewed changes

rustbot added the lint-nominated Create an FCP-thread on Zulip for this PR label Sep 4, 2026

CommanderStorm mentioned this pull request Sep 6, 2026

Unused import prefixes #17246

Open

6 tasks done

Conversation

lengyijun commented Nov 7, 2024 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Known problem

TODO

Question

Uh oh!

rustbot commented Nov 7, 2024

Uh oh!

Uh oh!

llogiq commented Jan 10, 2025

Uh oh!

llogiq commented Jan 25, 2025

Uh oh!

Uh oh!

Uh oh!

lengyijun commented Jan 30, 2025

Uh oh!

lengyijun commented Jan 31, 2025

Uh oh!

llogiq commented Feb 2, 2025

Uh oh!

lengyijun commented Feb 3, 2025

Uh oh!

rustbot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

lengyijun commented Sep 3, 2026

Uh oh!

Jarcho Sep 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jarcho commented Sep 4, 2026

Uh oh!

rustbot commented Sep 4, 2026

Uh oh!

rustbot commented Oct 11, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lengyijun commented Nov 7, 2024 •

edited by rustbot

Loading

Jarcho Sep 4, 2026 •

edited by rustbot

Loading