Skip to content

regression: transmute_copy validates sizing #100545

Description

@Mark-Simulacrum

transmute_copy now validates reasonable sizes and panics if not as of #98839, this causes some breakage (detected at the time in #98839 (comment)).

Mostly filing this issue to make sure we add a release notes compat note about this, but I don't expect us to do anything further. Nominating for T-libs-api, though, mostly just for awareness.

cc @tmandry / @joshtriplett -- let's make sure this makes it into 1.64 release notes

Activity

  1. added this to the 1.64.0 milestone on Aug 14, 2022
  2. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Aug 14, 2022
  3. removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Aug 14, 2022
  4. estebank commented on Aug 15, 2022

    @estebank
    Contributor

    I believe this is the same as #99923

    Edit: I meant "the same category as".

  5. Mark-Simulacrum commented on Aug 15, 2022

    @Mark-Simulacrum
    MemberAuthor

    Seems like a much easier issue to explain, at least - not sure I would quite call it "same as" pointer/integer transmutes :) Though the overall effect of breaking unsafe code seems quite similar.

  6. RalfJung commented on Aug 15, 2022

    @RalfJung
    Member

    I believe this is the same as #99923

    The issues seem entirely unrelated to me, in which sense are they "the same"?

  7. RalfJung commented on Aug 15, 2022

    @RalfJung
    Member

    Or did you mean they are broadly the same category, being related to UB detection? But even then, #99923 is about compile-time UB, and this here is primarily about run-time UB, and those are very different in how we treat them.

  8. RalfJung commented on Aug 15, 2022

    @RalfJung
    Member

    Yeah, we could have a cfg_attr(debug_assertions, track_caller) but that would only help once we have a good system for letting people use a debug build of the standard library...

  9. added
    relnotesMarks issues that should be documented in the release notes of the next release.
    on Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-libs-api[DEPRECATED; DO NOT USE]regression-from-stable-to-betaPerformance or correctness regression from stable to beta.relnotesMarks issues that should be documented in the release notes of the next release.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions