Can we add a new StableLintExpectationId type so we can remove unstable Hash impls #101751

Activity

1. oli-obk

   added

   C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.

   on Sep 13, 2022
2. xFrednet

   added

   F-lint_reasons`#![feature(lint_reasons)]``#![feature(lint_reasons)]`

   on Sep 13, 2022
3. Urgau commented on Sep 20, 2024

   

   Urgau

   on Sep 20, 2024

   Member

   More actions

   Seems to have been done.

   rust/compiler/rustc_lint_defs/src/lib.rs

   Lines 93 to 102 in 976487c

   	pub enum LintExpectationId {
   	/// Used for lints emitted during the `EarlyLintPass`. This id is not
   	/// hash stable and should not be cached.
   	Unstable { attr_id: AttrId, lint_index: Option<u16> },
   	/// The [`HirId`] that the lint expectation is attached to. This id is
   	/// stable and can be cached. The additional index ensures that nodes with
   	/// several expectations can correctly match diagnostics to the individual
   	/// expectation.
   	Stable { hir_id: HirId, attr_index: u16, lint_index: Option<u16> },
   	}
4. Urgau

   closed this as completedon Sep 20, 2024