missing generic_associated_types stabilisation version?

@jackh726

#![feature(generic_associated_types)]
pub fn main() {}

with rustc master rustc 1.65.0-nightly (5338f5f1d 2022-09-13)

warning: the feature `generic_associated_types` has been stable since CURRENT_RUSTC_VERSION and no longer requires an attribute to enable
 --> f.rs:1:12
  |
1 | #![feature(generic_associated_types)]
  |            ^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(stable_features)]` on by default

warning: 1 warning emitted

looks like the stabilisation version is borked? 😅
cc @jackh726

Hm, it actually says it like this in the code :D
https://github.com/rust-lang/rust/pull/96709/files#diff-307e0d3a2037c11a3fa16822fbaa0fec08e57ac7d0d6e7354f6005c9482a9e26R165

@est31

This is correct, but not ideal: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#updating-the-feature-gate-listing

cc @est31 maybe we want to special case this in the diagnostics

@rustbot

Yeah seems I've missed correcting that lint. For GATs, the stabilization version will be adjusted very soon, in the coming days, as we are close to the release cycle. But this needs to be fixed for future stabilizations as well. Working on a PR. @rustbot label bug

Error: Label bug can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Yeah it warns correctly for lib features so only lang features are affected:

warning: the feature `io_read_to_string` has been stable since 1.65.0-nightly and no longer requires an attribute to enable
 --> src/main.rs:1:12
  |
1 | #![feature(io_read_to_string)]
  |            ^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(stable_features)]` on by default

PR filed: #101772

Rollup merge of rust-lang#101772 - est31:replace_placeholder_diagnost…

Navigation Menu

Repository navigation

missing `generic_associated_types` stabilisation version? #101766

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

missing generic_associated_types stabilisation version? #101766

Description

Activity

matthiaskrgr commented on Sep 13, 2022

jackh726 commented on Sep 13, 2022

est31 commented on Sep 13, 2022

rustbot commented on Sep 13, 2022

est31 commented on Sep 13, 2022

est31 commented on Sep 13, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

missing `generic_associated_types` stabilisation version? #101766