Skip to content

Stabilize raw-dylib for non-x86 #102793

Description

@wesleywiser

The raw-dylib feature was proposed for stabilization for non-x86 targets in #99916 which the compiler team FCP'd and merged but forgot to tag T-lang as well. Sorry about that!

Since that PR has already been FCP'd rfcbot won't allow me to start another FCP on it so I'm creating this issue to act as T-lang's FCP.

This stabilizes the raw-dylib and link_ordinal features (#58713) for non-x86 architectures (i.e., x86_64, aarch64 and thumbv7a)

Link to stabilization report

I'm also tagging this I-lang-nominated to ensure discussion of this happens prior to the next release so we can either confirm the stabilization of the feature or revert the stabilization before the next release.

Activity

  1. added
    T-langRelevant to the language team
    F-raw_dylib`#![feature(raw_dylib)]`
    I-lang-nominatedNominated for discussion during a lang team meeting.
    on Oct 7, 2022
  2. joshtriplett commented on Oct 7, 2022

    @joshtriplett
    Member

    @rfcbot merge

  3. rfcbot commented on Oct 7, 2022

    @rfcbot

    Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  4. added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
    on Oct 7, 2022
  5. nikomatsakis commented on Oct 11, 2022

    @nikomatsakis
    Contributor

    @rfcbot reviewed

  6. added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    and removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Oct 11, 2022
  7. rfcbot commented on Oct 11, 2022

    @rfcbot

    🔔 This is now entering its final comment period, as per the review above. 🔔

  8. added
    to-announceAnnounce this issue on triage meeting
    and removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Oct 21, 2022
  9. rfcbot commented on Oct 21, 2022

    @rfcbot

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    This will be merged soon.

  10. wesleywiser commented on Oct 22, 2022

    @wesleywiser
    MemberAuthor

    Since this already merged in #99916, I'm going to go ahead and close this issue.

  11. removed
    I-lang-nominatedNominated for discussion during a lang team meeting.
    on Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    F-raw_dylib`#![feature(raw_dylib)]`T-langRelevant to the language teamdisposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions