Repository navigation
regression: associated consts cannot be referenced in patterns #103242
Copy link
Copy link
Closed
Labels
E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleP-criticalCritical priorityCritical priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Milestone
Description
Really bad spans in all of these (not related to this bug, I expect), but still a pretty wide ranging regression.
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/ChenYunShu-01.substrate-ink/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/MSghais.flat_contract_mmr/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/Mrhealer.erc20_rust/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/apemon.ink-amm-demo/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/forgetso.ink-events-debug/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/kmcodesdev.Increaser--Contract/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/ljl222.ink_erc20/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/gh/marlowl.ink-voter-contract/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/reg/accumulate-3.0.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/reg/erc1155-3.0.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/reg/erc721-3.0.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/reg/flipper-3.0.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/reg/incrementer-3.0.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/reg/trait_erc20-3.0.0/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.65-2/beta-2022-10-11/reg/zkink-0.0.1/log.txt
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleP-criticalCritical priorityCritical priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.
Activity
boulanlo commentedon Oct 19, 2022
Hi! A bit new to Rust contributing, but I saw this got a "needs bisection" label and thought I'd try to help. I picked the crate from the last log in the list (
zkink).I've managed to run the
cargo-bisect-rustctool up to the actual nightly that regressed (nightly-2022-09-09), but couldn't go further due to weird download issues with the actual commits.Here's the list of relevant commits the tool has found:
Out of all of these, I think #98900 looks like the culprit the most, seeing it has something to do with associated consts. I may be wrong though, and I didn't investigate the actual error.
(I hope that I bisected correctly; since I am on NixOS, I've ran into some trouble getting patched executables when bisecting, and since I'm seeing a PR about lld in the commit list, I'm afraid I messed up somehow!)
Mark-Simulacrum commentedon Oct 19, 2022
Cc @lcnr as author of #98900
compiler-errors commentedon Oct 20, 2022
This is also fixed by #103279.
apiraino commentedon Oct 20, 2022
WG-prioritization assigning priority (Zulip discussion).
@rustbot label -I-prioritize +P-critical
compiler-errors commentedon Nov 3, 2022
1.65 is released