Skip to content

regression: associated consts cannot be referenced in patterns #103242

Closed

Description

@Mark-Simulacrum

Really bad spans in all of these (not related to this bug, I expect), but still a pretty wide ranging regression.

Activity

  1. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
    on Oct 19, 2022
  2. added this to the 1.65.0 milestone on Oct 19, 2022
  3. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Oct 19, 2022
  4. boulanlo commented on Oct 19, 2022

    @boulanlo

    Hi! A bit new to Rust contributing, but I saw this got a "needs bisection" label and thought I'd try to help. I picked the crate from the last log in the list (zkink).

    I've managed to run the cargo-bisect-rustc tool up to the actual nightly that regressed (nightly-2022-09-09), but couldn't go further due to weird download issues with the actual commits.

    Here's the list of relevant commits the tool has found:

    found 9 bors merge commits in the specified range
      commit[0] 2022-09-07UTC: Auto merge of #101544 - matthiaskrgr:rollup-4urx917, r=matthiaskrgr
      commit[1] 2022-09-07UTC: Auto merge of #94075 - mikebenfield:wip-enum, r=oli-obk
      commit[2] 2022-09-08UTC: Auto merge of #101303 - jyn514:jnelson/handle-cycle-enum, r=cjgillot
      commit[3] 2022-09-08UTC: Auto merge of #101504 - lqd:rust-lld-fix, r=petrochenkov
      commit[4] 2022-09-08UTC: Auto merge of #101560 - Dylan-DPC:rollup-8m8yr89, r=Dylan-DPC
      commit[5] 2022-09-08UTC: Auto merge of #98900 - lcnr:region-stuff, r=jackh726
      commit[6] 2022-09-08UTC: Auto merge of #101467 - nnethercote:shrink-hir-Ty-Pat, r=spastorino
      commit[7] 2022-09-08UTC: Auto merge of #101577 - Dylan-DPC:rollup-l9xw7i7, r=Dylan-DPC
      commit[8] 2022-09-08UTC: Auto merge of #101437 - compiler-errors:erase-normalize-ordering, r=tmandry
    

    Out of all of these, I think #98900 looks like the culprit the most, seeing it has something to do with associated consts. I may be wrong though, and I didn't investigate the actual error.

    (I hope that I bisected correctly; since I am on NixOS, I've ran into some trouble getting patched executables when bisecting, and since I'm seeing a PR about lld in the commit list, I'm afraid I messed up somehow!)

  5. Mark-Simulacrum commented on Oct 19, 2022

    @Mark-Simulacrum
    MemberAuthor

    Cc @lcnr as author of #98900

  6. removed
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    on Oct 19, 2022
  7. compiler-errors commented on Oct 20, 2022

    @compiler-errors
    Contributor

    This is also fixed by #103279.

  8. apiraino commented on Oct 20, 2022

    @apiraino
    Contributor

    WG-prioritization assigning priority (Zulip discussion).

    @rustbot label -I-prioritize +P-critical

  9. added and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Oct 20, 2022
  10. compiler-errors commented on Nov 3, 2022

    @compiler-errors
    Contributor

    1.65 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleP-criticalCritical priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions