Recover from common if let syntax mistakes/typos

Given the following code: link

fn main() {
    let x = Some(123);

    // #1
    if let Some(_) == x {}

    // #2
    if let x = Some(_) {}

    // #3
    if let x == Some(_) {}

    // #4
    if Some(_) = x {}
}

The current output is:

   Compiling playground v0.0.1 (/playground)
error: expected one of `=` or `|`, found `==`
 --> src/main.rs:5:20
  |
5 |     if let Some(_) == x {}
  |                    ^^ expected one of `=` or `|`

error: could not compile `playground` due to previous error

Ideally the output should suggest how to fix the syntax mistakes/typos for each of the above examples.
1 -> Remove extra =
2 -> Swap x and Some(_)
3 -> 1 and 2
4 -> Add let

@rustbot

@rustbot claim

Submit #103636 to resolve scenario 1 and 4, because I think we are sure about the intention of developer, and there is a clear way to fix it.

For 2 and 3, there are several potential ways to fix the code, so give a specific suggestion may not correct.

fix rust-lang#103587, Recover from common if let syntax mistakes/typos

Rollup merge of rust-lang#103636 - chenyukang:yukang/fix-103587-sugg-…

Auto merge of rust-lang#103636 - chenyukang:yukang/fix-103587-sugg-if…

Navigation Menu

Repository navigation

Recover from common `if let` syntax mistakes/typos #103587

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Recover from common if let syntax mistakes/typos #103587

Description

Activity

chenyukang commented on Oct 27, 2022

chenyukang commented on Oct 27, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Recover from common `if let` syntax mistakes/typos #103587