Skip to content

regression: parameter may not live long enough #104445

Closed
Closed
regression: parameter may not live long enough#104445
Labels
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
Milestone
1.66.0

Description

@Mark-Simulacrum
Mark-Simulacrum
opened on Nov 15, 2022
[INFO] [stdout] error[E0309]: the parameter type `T` may not live long enough
[INFO] [stdout]    --> src/validate.rs:245:13
[INFO] [stdout]     |
[INFO] [stdout] 245 |             validate_post_dispute_for_existing_tx(post, disputed_tx, accounts, disputes)
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ...so that the type `T` will meet its required lifetime bounds
[INFO] [stdout]     |
[INFO] [stdout] help: consider adding an explicit lifetime bound...
[INFO] [stdout]     |
[INFO] [stdout] 228 | pub fn validate_post_dispute<'a, 't, 'd, T: PostDispute + 't>(
[INFO] [stdout]     |                                                         ++++
[INFO] [stdout] 
[INFO] [stdout]

Activity

  1. Mark-Simulacrum
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
    on Nov 15, 2022
  2. Mark-Simulacrum
    added this to the 1.66.0 milestone on Nov 15, 2022
  3. rustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Nov 15, 2022

  4. apiraino commented on Nov 15, 2022

    @apiraino
    apiraino
    on Nov 15, 2022
    Contributor

    I've bisected the first and last crate in the list, both point to commit f5193a9 -> #95474 cc @oli-obk

    bisected with cargo-bisect-rustc v0.6.0

    Host triple: x86_64-unknown-linux-gnu
    Reproduce with:

    cargo bisect-rustc 2022-03-01 --preserve

  5. apiraino commented on Nov 15, 2022

    @apiraino
    apiraino
    on Nov 15, 2022
    Contributor

    since they're regressions on existing crates, let's label them as P-critical out of caution to signal that we want them checked before the next stable

    @rustbot label -I-prioritize +P-critical

  6. rustbot
    added
    P-criticalCritical priority
    and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Nov 15, 2022

  7. Mark-Simulacrum commented on Nov 15, 2022

    @Mark-Simulacrum
    Mark-Simulacrum
    on Nov 15, 2022
    MemberAuthor

    It doesn't look like they were noted in the PR run (unless I'm missing the relevant comment). I think given the volume of breakage it likely makes sense to move ahead, but it would be great to put up PRs to these crates.

  8. oli-obk commented on Nov 15, 2022

    @oli-obk
    oli-obk
    on Nov 15, 2022
    Contributor

  9. apiraino commented on Nov 15, 2022

    @apiraino
    apiraino
    on Nov 15, 2022
    Contributor

    ah nice, thanks @oli-obk for the additional context :)

    @rustbot label -P-critical

  10. rustbot
    removed
    P-criticalCritical priority
    on Nov 15, 2022

  11. Mark-Simulacrum commented on Dec 9, 2022

    @Mark-Simulacrum
    Mark-Simulacrum
    on Dec 9, 2022
    MemberAuthor

    This is known breakage, not release blocking, and is mentioned in release notes (https://github.com/rust-lang/rust/pull/104405/files#diff-4a00447b47c36ebd3ded77321deff288e424f4605496ee1199fc9953a20f4473R77). Resolving.

  12. Mark-Simulacrum
    closed this as completedon Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions