Repository navigation
Regression 1.67.0: Static archives have different unix permissions than before #107495
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-linkageArea: linking into static, shared libraries and binariesArea: linking into static, shared libraries and binariesT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Activity
#107360 reverted back to the LLVM archive writer to fix another regression. Still I think this issuw should be kept open as a reminder to fix the new archive writer before it becomes the default again.
Reacted by jyn- addedA-linkageArea: linking into static, shared libraries and binariesArea: linking into static, shared libraries and binariesT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
on Apr 8, 2023 cc #107407, which also needs to be fixed before relanding the archive writer change. BTW @bjorn3 is there a tracking issue for that somewhere? I see the original PR linked to https://github.com/bjorn3/rustc_codegen_cranelift/issues/1155, but it hasn't been reopened.
I have kept all issues that need to be fixed before it can land again in my github notifications. There is currently no tracking issue, but feel free to open one. It did probably be a good idea to ensure no issue is forgotten about.
Reacted by jyn- added 3 commits that reference this issue
on Mar 20, 2024 - added a commit that references this issue
on Mar 22, 2024 - added a commit that references this issue
on Apr 17, 2024 - added a commit that references this issue
on Apr 17, 2024 - added 3 commits that reference this issue
on Aug 12, 2024 - added a commit that references this issue
on Aug 17, 2024 - added a commit that references this issue
on Aug 29, 2024
Metadata
Metadata
Assignees
Labels
A-linkageArea: linking into static, shared libraries and binariesArea: linking into static, shared libraries and binariesT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Given this code:
I get this output from rustc:
The most recent archive no longer has the "read" permission bit set for group/world owners. This ended up breaking Wasmtime's build because our files are built in a container with a different user and aren't then readable outside of the container. There's no particular reason we do this and we can work around this, but I also suspected that the change in permissions here probably wasn't intentional.
I think this is due to #97485 (cc @bjorn3), specifically this line. I haven't dug too deeply but my guess is that temp files specifically turn off other permission bits