Skip to content

regression: cannot move out of shared reference #109744

Description

@Mark-Simulacrum

I suspect these may relate to the packed hard error, but it's not very clear what has changed here. Maybe a bisection will help. (I seem to recall a change in derive desugaring, maybe this is caused by that? It did have known regressions at the time, IIRC, though this seems like more than I recall).

Activity

  1. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    on Mar 30, 2023
  2. added this to the 1.69.0 milestone on Mar 30, 2023
  3. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Mar 30, 2023
  4. lqd commented on Mar 30, 2023

    @lqd
    Member

    I think it's indeed because the packed hard error and derive on packed structs changes both landed in 1.69.

    twain-0.1.0, icu_locale_canonicalizer-0.6.0, or mars-research.binunpack-rs, all bisect to the latter, but the fact that they compiled on crater since 1.62 is likely because the deny-by-default lint was capped.

  5. removed
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Mar 30, 2023
  6. Mark-Simulacrum commented on Mar 30, 2023

    @Mark-Simulacrum
    MemberAuthor

    Yep, sounds right. #104429 (comment) is the comment with explanation of the changes in derive on packed structs.

    Removing prioritization, this seems like something we can just mention in relnotes as expected breakage.

  7. added
    regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.
    and removed on May 26, 2023
  8. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on May 26, 2023
  9. removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on May 26, 2023
  10. Enselic commented on Jun 26, 2024

    @Enselic
    Member

    Triage: Not sure if this was mentioned in the release notes.

    If it was not mentioned, it seems weird to do now.

    If it was mentioned, there is no further action to take as far as I can tell.

    Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions