Skip to content

symlinking is not working as expected on x build #110625

Closed
#110365
Closed
symlinking is not working as expected on x build#110625
#110365
Assignees
onur-ozkan
Labels
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@onur-ozkan
onur-ozkan
opened on Apr 20, 2023

Because of the early return here:

rust/src/bootstrap/compile.rs

Lines 1331 to 1335 in 3d7a091

return INTERNER.intern_path(sysroot);
}
// Symlink the source root into the same location inside the sysroot,
// where `rust-src` component would go (`$sysroot/lib/rustlib/src/rust`),

symlinking phases are bypassed which causes tools like miri can't find rust-src.

Activity

  1. onur-ozkan
    added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Apr 20, 2023
  2. onur-ozkan
    self-assigned this
    on Apr 20, 2023
  3. onur-ozkan
    changed the title [-]symlinking is not working as expected after #104076[/-] [+]symlinking is not working as expected on `x build`[/+] on Apr 20, 2023
  4. matthiaskrgr
    added a commit that references this issue on Apr 21, 2023

    Rollup merge of rust-lang#110365 - ozkanonur:ship-tools-with-sysroot,…

    f2321ec
  5. bors
    closed this as completedin f2321econ Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions