Skip to content

Rustdoc doesn't show repr for a struct re-exported from another package #110698

Closed
#110901
Closed
Rustdoc doesn't show repr for a struct re-exported from another package#110698
#110901
Assignees
GuillaumeGomez
Labels
A-ABIArea: Concerning the application binary interface (ABI)A-cross-crate-reexportsArea: Documentation that has been re-exported from a different crateC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Description

@nicholasbishop
nicholasbishop
opened on Apr 22, 2023

If you define a struct with an explicit repr(...) in one package, then pub use it in another package, rustdoc doesn't show the repr on the re-exported one.

Minimal repo showing this problem: https://github.com/nicholasbishop/pub-use-repr-doc-bug

In pkg1 you get:
image

But in pkg2 you get:
image

Meta

rustc --version --verbose:

rustc 1.69.0 (84c898d65 2023-04-16)
binary: rustc
commit-hash: 84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc
commit-date: 2023-04-16
host: x86_64-unknown-linux-gnu
release: 1.69.0
LLVM version: 15.0.7

Also tested on nightly, same result:

rustc 1.71.0-nightly (8bdcc62cb 2023-04-20)
binary: rustc
commit-hash: 8bdcc62cb0362869f0e7b43a6ae4f96b953d3cbc
commit-date: 2023-04-20
host: x86_64-unknown-linux-gnu
release: 1.71.0-nightly
LLVM version: 16.0.2

Activity

  1. nicholasbishop
    added
    C-bugCategory: This is a bug.
    on Apr 22, 2023

  2. Ezrashaw commented on Apr 24, 2023

    @Ezrashaw
    Ezrashaw
    on Apr 24, 2023
    Contributor

    I suspect that this kind of metadata isn't saved to disk and therefore rustdoc has no idea about the existence of the attribute on foreign types.

  3. jyn514
    added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    A-cross-crate-reexportsArea: Documentation that has been re-exported from a different crate
    A-ABIArea: Concerning the application binary interface (ABI)
    on Apr 27, 2023

  4. GuillaumeGomez commented on Apr 27, 2023

    @GuillaumeGomez
    GuillaumeGomez
    on Apr 27, 2023
    Member

    That's a regression actually since it was there before #98450. Fixing it.

  5. GuillaumeGomez
    self-assigned this
    on Apr 27, 2023
  6. GuillaumeGomez
    added a commit that references this issue on Apr 27, 2023

    Add regression test for rust-lang#110698

    3f08284

  7. nicholasbishop commented on Apr 27, 2023

    @nicholasbishop
    nicholasbishop
    on Apr 27, 2023
    ContributorAuthor

    Great, thanks for the quick fix!

  8. GuillaumeGomez
    added a commit that references this issue on Apr 28, 2023

    Rollup merge of rust-lang#110901 - GuillaumeGomez:inlined-repr-rustdo…

    48413b8
  9. bors
    closed this as completedin f495605on Apr 28, 2023
  10. bindsdev
    added a commit that references this issue on Apr 29, 2023

    Add regression test for rust-lang#110698

    a692173
  11. RalfJung
    added a commit that references this issue on Apr 30, 2023

    Auto merge of #110901 - GuillaumeGomez:inlined-repr-rustdoc, r=notriddle

    cd0001d
  12. RalfJung
    added a commit that references this issue on Apr 20, 2024

    Auto merge of #110901 - GuillaumeGomez:inlined-repr-rustdoc, r=notriddle

    1400757
  13. RalfJung
    added a commit that references this issue on Apr 27, 2024

    Auto merge of #110901 - GuillaumeGomez:inlined-repr-rustdoc, r=notriddle

    182ca6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-ABIArea: Concerning the application binary interface (ABI)A-cross-crate-reexportsArea: Documentation that has been re-exported from a different crateC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions