Skip to content

1.70.0: ui test failures due to "the full type name has been written to" #112209

Closed
Closed
1.70.0: ui test failures due to "the full type name has been written to"#112209
Assignees
chenyukang
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcE-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.P-lowLow priorityregression-from-stable-to-stablePerformance or correctness regression from one stable version to another.

Description

@xry111
xry111
opened on Jun 2, 2023

Three ui tests fail with 1.70.0 and channel = "stable":

[ui] tests/ui/mismatched_types/issue-36053-2.rs
[ui] tests/ui/typeck/issue-31173.rs
[ui] tests/ui/methods/method-not-found-generic-arg-elision.rs

They seem caused by the extra lines like:

= note: the full type name has been written to '$TEST_BUILD_DIR/methods/method-not-found-generic-arg-elision/method-not-found-generic-arg-elision.long-type-9165007450593903927.txt'

Should we suppress the "full type name output" within the test suite, or am I doing something wrong?

Activity

  1. TimNN commented on Jun 3, 2023

    @TimNN
    TimNN
    on Jun 3, 2023
    Contributor

    Some background:

    I've attempted to fix this in #105924 by enabling path remapping in UI tests by default.

    However, that caused some usability regressions for rustc developers (#109725), so now this logic only triggers on CI: #110115

  2. jyn514 commented on Jun 3, 2023

    @jyn514
    jyn514
    on Jun 3, 2023
    Member

    i wonder if this should be an explicit config instead of being auto detected based on a CI environment variable. then we could enable it by default for the dev channel and disable it everywhere else.

  3. jyn514
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.
    on Jun 3, 2023
  4. rustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Jun 3, 2023

  5. TimNN commented on Jun 3, 2023

    @TimNN
    TimNN
    on Jun 3, 2023
    Contributor

    Having an explicit config for this sounds great. It would also mean that people with custom buildbots no longer need to spoof the CI detection logic (like e.g. Chromium does right now: chromium/chromium@9fc3ea5).

  6. jyn514
    added
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    on Jun 3, 2023

  7. apiraino commented on Jun 5, 2023

    @apiraino
    apiraino
    on Jun 5, 2023
    Contributor

    WG-prioritization assigning priority (Zulip discussion).

    @rustbot label -I-prioritize +P-low

  8. rustbot
    added
    P-lowLow priority
    and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Jun 5, 2023
  9. chenyukang
    self-assigned this
    on Aug 15, 2023

  10. chenyukang commented on Aug 23, 2023

    @chenyukang
    chenyukang
    on Aug 23, 2023
    Member

    The path remapping is removed in #114090, I verified the test issue in the stable channel is fixed, closing this issue now.

  11. chenyukang
    closed this as completedon Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcE-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.P-lowLow priorityregression-from-stable-to-stablePerformance or correctness regression from one stable version to another.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions