Skip to content

finish and clean up rustc_const_eval's translatable diagnostics. #113117

Closed
#153611
Closed
finish and clean up rustc_const_eval's translatable diagnostics.#113117
#153611
Labels
A-const-evalArea: Constant evaluation, covers all const contexts (static, const fn, ...)A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Description

@fee1-dead
fee1-dead
opened on Jun 28, 2023

For some context see this Zulip topic.

cc @RalfJung.

This issue has a few parts:

In #111677 I added a trait called ReportErrorExt which should be replaced by implementing IntoDiagnostic for newtypes. Another thing would be to investigate if the same can be done for MachineStopType which requires being made into a trait object.

this is an example of using fluent's pattern matching for different error messages. These should be eventually replaced by individual messages with their own identifiers instead of pattern matching.

I'll assign this to myself when I get time. Feel free to claim if this is unassigned.

Activity

  1. fee1-dead
    added
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
    A-const-evalArea: Constant evaluation, covers all const contexts (static, const fn, ...)
    A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
    on Jun 28, 2023

  2. victor-timofei commented on Jun 30, 2023

    @victor-timofei
    victor-timofei
    on Jun 30, 2023

    @rustbot claim
    I would love to help with this

  3. rustbot
    assigned
    victor-timofei
    on Jun 30, 2023

  4. fee1-dead commented on Jun 30, 2023

    @fee1-dead
    fee1-dead
    on Jun 30, 2023
    MemberAuthor

    Hi @victor-timofei, thanks for claiming this! Feel free to open a thread on Zulip and ping me if you get stuck.

  5. RalfJung commented on Aug 19, 2023

    @RalfJung
    RalfJung
    on Aug 19, 2023
    Member

    this is an example of using fluent's pattern matching for different error messages. These should be eventually replaced by individual messages with their own identifiers instead of pattern matching.

    That link doesn't seem to work here. What are you referring to?

  6. fee1-dead commented on Aug 19, 2023

    @fee1-dead
    fee1-dead
    on Aug 19, 2023
    MemberAuthor

    See this

  7. CastilloDel commented on Oct 24, 2024

    @CastilloDel
    CastilloDel
    on Oct 24, 2024
    Contributor

    @rustbot claim

  8. rustbot
    assigned
    CastilloDel
    and unassigned
    victor-timofei
    on Oct 24, 2024

  9. CastilloDel commented on Oct 24, 2024

    @CastilloDel
    CastilloDel
    on Oct 24, 2024
    Contributor

    @rustbot release-assignment

  10. rustbot
    unassigned
    CastilloDel
    on Oct 24, 2024

  11. JayanAXHF commented on Jan 11, 2026

    @JayanAXHF
    JayanAXHF
    on Jan 11, 2026
    Member

    Is this issue still open to contribution?

  12. RalfJung commented on Jan 11, 2026

    @RalfJung
    RalfJung
    on Jan 11, 2026
    Member

    Let's wait until rust-lang/compiler-team#959 is resolved before doing anything here.

    The next step then probably is to entirely remove the use of fluent for const-eval errors: we already have our own error types providing the benefits people ascribe to error structs (I think); we should just go back to translating those error types directly into strings IMO.

  13. JonathanBrouwer
    added 2 commits that reference this issue on Mar 11, 2026

    Rollup merge of rust-lang#153611 - RalfJung:interp-error-strings, r=o…

    78bf4eb

    Rollup merge of rust-lang#153611 - RalfJung:interp-error-strings, r=o…

    77134bd
  14. rust-bors
    closed this as completedin 77134bdon Mar 12, 2026
  15. github-actions
    added a commit that references this issue on Mar 12, 2026

    Rollup merge of #153611 - RalfJung:interp-error-strings, r=oli-obk

    a15a733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-const-evalArea: Constant evaluation, covers all const contexts (static, const fn, ...)A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions