Repository navigation
Invalid unused export warning on 1.75.0-nightly (cd674d617 2023-10-24) #117120
Description
CI started failing for us, without code changes in this area today with nightly
The code is sth like this
mod keys;
pub use keys::*;and produces
error: unused import: `keys::*`
--> iroh-sync/src/lib.rs:44:9
|
44 | pub use keys::*;
| ^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
but it should not, given that this is a public export in src/lib.rs.
Version with regression
latest update on 2023-10-24, rust version 1.75.0-nightly (cd674d617 2023-10-24)
Logs
CI logs: https://github.com/n0-computer/iroh/actions/runs/6624632107/job/17994903346?pr=1708
Activity
dignifiedquire commentedon Oct 24, 2023
Okay, I am very confused, now this got triggered on stable as well: https://github.com/n0-computer/iroh/actions/runs/6625039736/job/17995549252
dignifiedquire commentedon Oct 24, 2023
Can reproduce the warning on my local machine using
but
does not trigger it
bvanjoi commentedon Oct 24, 2023
This behavior introduced through #116033.
And I think this behavior is indeed expected because
iroh-sync::keys::*has been re-exported iniroh-sync::syncsopub use keys::*is not used: https://github.com/n0-computer/iroh/blob/main/iroh-sync/src/sync.rs#L28Teapot4195 commentedon Oct 24, 2023
Behavior seems correct, just not very obvious why. Maybe the warning should print out why the symbol might be unused?
dignifiedquire commentedon Oct 24, 2023
I see, thanks a lot, that was definitely on the confusing side, but glad the compiler catches it now :)
dignifiedquire commentedon Oct 24, 2023
Agreed, I wonder if it could print out a warning about the shadowing of the reexport.
fix unused export found in nightly rust (#1719)
fix unused export found in nightly rust (#1719)