Skip to content

rename config.toml to bootstrap.toml #126875

Closed
#137081
Closed
rename config.toml to bootstrap.toml#126875
#137081
Assignees
bit-aloo
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@jyn514
jyn514
opened on Jun 23, 2024

cargo and bootstrap use the same name for their configuration file. this is confusing. we might want to rename this file so it's easier to understand what's going on.

this will also make it easier to write .gitignore style includes and excludes without mixing up the two types of configs.

@rustbot label A-contributor-roadblock T-bootstrap E-easy E-mentor

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rust
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Jun 23, 2024
  2. onur-ozkan
    removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 24, 2024

  3. onur-ozkan commented on Jun 24, 2024

    @onur-ozkan
    onur-ozkan
    on Jun 24, 2024
    Contributor

    If we do that, if bootstrap.toml don't exist we should fallback to config.toml so we don't break the downstreams.

  4. Noratrieb commented on Jul 7, 2024

    @Noratrieb
    Noratrieb
    on Jul 7, 2024
    Member

    our docs have also been confused about this before: #127236

  5. LuuuXXX commented on Jul 8, 2024

    @LuuuXXX
    LuuuXXX
    on Jul 8, 2024
    Contributor

    Any progress on this? I'm happy to help.

  6. onur-ozkan commented on Jul 8, 2024

    @onur-ozkan
    onur-ozkan
    on Jul 8, 2024
    Contributor

    Any progress on this? I'm happy to help.

    Feel free to claim the task.

  7. LuuuXXX commented on Jul 8, 2024

    @LuuuXXX
    LuuuXXX
    on Jul 8, 2024
    Contributor

    @rustbot claim

  8. rustbot
    assigned
    LuuuXXX
    on Jul 8, 2024
  9. rustbot
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    on Feb 14, 2025

  10. bit-aloo commented on Feb 14, 2025

    @bit-aloo
    bit-aloo
    on Feb 14, 2025
    Member

    @rustbot claim

  11. rustbot
    assigned
    bit-aloo
    and unassigned
    LuuuXXX
    on Feb 14, 2025
  12. matthiaskrgr
    added 2 commits that reference this issue on Mar 1, 2025

    Rollup merge of rust-lang#137081 - Shourya742:2025-02-15-change-confi…

    58cee66

    Rollup merge of rust-lang#137081 - Shourya742:2025-02-15-change-confi…

    d156259
  13. bors
    added 2 commits that reference this issue on Mar 11, 2025

    Auto merge of rust-lang#137081 - Shourya742:2025-02-15-change-config.…

    f710d56

    Auto merge of rust-lang#137081 - Shourya742:2025-02-15-change-config.…

    8279176
  14. bors
    closed this as completedin 8279176on Mar 17, 2025
  15. Kobzol
    added a commit that references this issue on Mar 18, 2025

    Auto merge of #137081 - Shourya742:2025-02-15-change-config.toml-to-b…

    82393cf
  16. github-actions
    added a commit that references this issue on Mar 20, 2025

    Auto merge of #137081 - Shourya742:2025-02-15-change-config.toml-to-b…

    7351fd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions