Bootstrap re-builds everything after "x.py check" #130108

Activity

1. rustbot

   added

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Sep 8, 2024
2. RalfJung

   added

   A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to Rust

   on Sep 8, 2024
3. matthiaskrgr

   added

   T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

   on Sep 8, 2024
4. onur-ozkan

   removed

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Sep 8, 2024
5. onur-ozkan commented on Sep 8, 2024

   

   onur-ozkan

   on Sep 8, 2024

   Contributor

   More actions

   I wonder if #128871 has anything to do with this.
6. RalfJung commented on Sep 8, 2024

   

   RalfJung

   on Sep 8, 2024 via email

   MemberAuthor

   More actions

   Yeah that sounds likely. Configuring the linker sets some env vars and when those differ between check and test builds, everything gets rebuilt.
7. RalfJung commented on Sep 9, 2024

   

   RalfJung

   on Sep 9, 2024

   MemberAuthor

   More actions

   Should we revert that PR then? Or is there some other short-term fix?

   This is a significant hurdle for rustc development right now.
8. Kobzol commented on Sep 9, 2024

   

   Kobzol

   on Sep 9, 2024

   Member

   More actions

   I suppose that we could for now just skip the check command from #128871. I tried the three commands that you have posted, and the last command did not rebuild anything (or rather, everything was fresh). What code should I modify between running these commands to reproduce the behavior that the third command rebuilds a lot of stuff?
9. Kobzol commented on Sep 9, 2024

   

   Kobzol

   on Sep 9, 2024

   Member

   More actions

   Nevermind, I reproduced it. And the fix with removing check from configuring the linker works. I'll send a PR.
10. onur-ozkan commented on Sep 9, 2024

    

    onur-ozkan

    on Sep 9, 2024

    Contributor

    More actions

    I think excluding check is quite good short-term fix.
11. bors

    added a commit that references this issue on Sep 9, 2024

    Auto merge of rust-lang#130135 - Kobzol:bootstrap-check-linker, r=onu…

    ...

    38e3a57
12. bors

    closed this as completedin 38e3a57on Sep 9, 2024
13. RalfJung

    added a commit that references this issue on Sep 10, 2024

    Auto merge of #130135 - Kobzol:bootstrap-check-linker, r=onur-ozkan

    ...

    a4de3b8
14. Zalathar

    added a commit that references this issue on May 4, 2025

    Rollup merge of rust-lang#140357 - onur-ozkan:133840, r=clubby789

    ...

    679b6ce
15. bors

    added a commit that references this issue on May 5, 2025

    Auto merge of rust-lang#140357 - onur-ozkan:133840, r=<try>

    ...

    0e3a7e6
16. GuillaumeGomez

    added 2 commits that reference this issue on May 5, 2025

    Rollup merge of rust-lang#140357 - onur-ozkan:133840, r=clubby789

    ...

    986ebd3

    Rollup merge of rust-lang#140357 - onur-ozkan:133840, r=clubby789

    ...

    246acdb
17. rust-timer

    added a commit that references this issue on May 6, 2025

    Unrolled build for rust-lang#140357

    ...

    5cd3369
18. github-actions

    added a commit that references this issue on May 10, 2025

    Rollup merge of #140357 - onur-ozkan:133840, r=clubby789

    ...

    45903cb