rust-url's debugger_visualizer tests are broken in rustc nightly-2024-08-13 #130431

Activity

1. valenting

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   regression-untriagedUntriaged performance or correctness regression.Untriaged performance or correctness regression.

   on Sep 16, 2024
2. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Sep 16, 2024
3. jieyouxu

   added

   WG-debuggingWorking group: Bad Rust debugging experiencesWorking group: Bad Rust debugging experiences

   on Sep 16, 2024
4. jieyouxu commented on Sep 16, 2024

   

   jieyouxu

   on Sep 16, 2024

   Member

   More actions

   cc @saethlin since you authored #126793 and are more familiar with debuggers
5. jieyouxu

   added

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   on Sep 16, 2024
6. saethlin

   added

   E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

   C-discussionCategory: Discussion or questions that doesn't represent real issues.Category: Discussion or questions that doesn't represent real issues.

   and removed

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   C-bugCategory: This is a bug.Category: This is a bug.

   E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   regression-untriagedUntriaged performance or correctness regression.Untriaged performance or correctness regression.

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Sep 16, 2024
7. saethlin commented on Sep 16, 2024

   

   saethlin

   on Sep 16, 2024

   Member

   More actions

   The issue is that you need to update your natvis file for the new level of nesting in Vec, probably this line:
   https://github.com/servo/rust-url/blob/22b823708a59a50ea2505c3fcdb5c4b26ab9b080/debug_metadata/url.natvis#L4

   You could use the changes to our own natvis file in that PR you bisected to as a guide.

   I've removed the regression and bug labels, because (unfortunately) doing cool debugger stuff like this means you are depending on unstable library internals. If only we could teach debuggers how to go through our stable APIs to get the information 🙃
8. valenting commented on Sep 17, 2024

   

   valenting

   on Sep 17, 2024

   Author

   More actions

   @saethlin thank you for the suggestion. Very much appreciated!
   Feel free to close this bug.
9. jieyouxu commented on Sep 17, 2024

   

   jieyouxu

   on Sep 17, 2024

   Member

   More actions

   Closing as unfortunately not super actionable in terms of rustc/std.
10. jieyouxu

    closed this as completedon Sep 17, 2024