Skip to content

Test failures in tests/ui/panics on aarch64-apple-darwin #133997

Closed

Description

@Zalathar

Using an unmodified profile = "compiler" build on aarch64 macOS (14.7.1), I see the following tests fail from ./x test tests/ui/panics:

failures:
    [ui] tests/ui/panics/issue-47429-short-backtraces.rs
    [ui] tests/ui/panics/runtime-switch.rs
    [ui] tests/ui/panics/short-ice-remove-middle-frames-2.rs
    [ui] tests/ui/panics/short-ice-remove-middle-frames.rs

All of the failure diffs look something like this:

diff of run.stderr:

1	thread 'main' panicked at $DIR/issue-47429-short-backtraces.rs:24:5:
2	explicit panic
3	stack backtrace:
-	   0: std::panicking::begin_panic
+	   0: begin_panic<&str>
5	   1: issue_47429_short_backtraces::main
6	note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
7	


The actual run.stderr differed from the expected run.stderr.

I see the same failures with --stage=1 and --stage=2.


Not sure if this is a test output normalization problem, or an actual bug.

Discussion elsewhere indicates that this might be related to #123244.

Activity

  1. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Dec 7, 2024
  2. Zalathar commented on Dec 7, 2024

    @Zalathar
    MemberAuthor

    I'm seeing the same failures with all of:

    rust.new-symbol-mangling = true
    rust.new-symbol-mangling = false
    # rust.new-symbol-mangling not set
    
  3. added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    A-panicArea: Panicking machinery
    E-needs-investigationCall for participation: This issues needs some investigation to determine current status
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Dec 7, 2024
  4. jieyouxu commented on Dec 7, 2024

    @jieyouxu
    Member

    I cannot repro on x86_64 linux, x86_64 msvc, aarch64 linux, tagging aarch64 + apple unless someone else can repro this on a different environment.

  5. added
    O-macosOperating system: macOS
    O-AArch64Armv8-A or later processors in AArch64 mode
    on Dec 7, 2024
  6. Zalathar commented on Dec 7, 2024

    @Zalathar
    MemberAuthor

    I can also confirm that for me the tests pass before #123244, and fail after it.

  7. jieyouxu commented on Dec 7, 2024

    @jieyouxu
    Member

    #123244 added some additional normalizations, FTR

  8. Mark-Simulacrum commented on Dec 7, 2024

    @Mark-Simulacrum
    Member

    We probably(?) need some extra normalization in the tests. The symbol in question (begin_panic) is probably found a bit differently by backtrace on this platform?

    That said, we run these tests in CI for this platform, so it's not clear whether it's some local delta as well. Perhaps you have e.g. lld enabled or some other optimization setting that's not set in CI?

  9. madsmtm commented on Dec 8, 2024

    @madsmtm
    Member

    I can reproduce it on my machine too (also using macOS 14.7.1), on both Aarch64 and x86_64 (using Rosetta), so that's at least weak evidence that it's not something environment specific.

    Not sure what the underlying issue is yet though.

  10. Zalathar commented on Dec 26, 2024

    @Zalathar
    MemberAuthor

    I can make the failures go away by setting rust.debuginfo-level = 1, and then make them appear again by setting rust.debuginfo-level = "line-tables-only", which is the compiler profile default.

    That helps to explain why it doesn't show up on CI.

  11. added a commit that references this issue on Dec 26, 2024
  12. added a commit that references this issue on Dec 26, 2024
  13. added a commit that references this issue on Dec 26, 2024
  14. Zalathar commented on Dec 27, 2024

    @Zalathar
    MemberAuthor

    Fixed by adding more normalizations in #134781.

  15. added a commit that references this issue on Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-panicArea: Panicking machineryA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.E-needs-investigationCall for participation: This issues needs some investigation to determine current statusO-AArch64Armv8-A or later processors in AArch64 modeO-macosOperating system: macOST-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions