You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Test failures in tests/ui/panics on aarch64-apple-darwin #133997
All of the failure diffs look something like this:
diff of run.stderr:
1 thread 'main' panicked at $DIR/issue-47429-short-backtraces.rs:24:5:
2 explicit panic
3 stack backtrace:
- 0: std::panicking::begin_panic
+ 0: begin_panic<&str>
5 1: issue_47429_short_backtraces::main
6 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
7
The actual run.stderr differed from the expected run.stderr.
I see the same failures with --stage=1 and --stage=2.
Not sure if this is a test output normalization problem, or an actual bug.
Discussion elsewhere indicates that this might be related to #123244.
We probably(?) need some extra normalization in the tests. The symbol in question (begin_panic) is probably found a bit differently by backtrace on this platform?
That said, we run these tests in CI for this platform, so it's not clear whether it's some local delta as well. Perhaps you have e.g. lld enabled or some other optimization setting that's not set in CI?
I can reproduce it on my machine too (also using macOS 14.7.1), on both Aarch64 and x86_64 (using Rosetta), so that's at least weak evidence that it's not something environment specific.
I can make the failures go away by setting rust.debuginfo-level = 1, and then make them appear again by setting rust.debuginfo-level = "line-tables-only", which is the compiler profile default.
That helps to explain why it doesn't show up on CI.
Activity
Zalathar commentedon Dec 7, 2024
I'm seeing the same failures with all of:
jieyouxu commentedon Dec 7, 2024
I cannot repro on x86_64 linux, x86_64 msvc, aarch64 linux, tagging aarch64 + apple unless someone else can repro this on a different environment.
Zalathar commentedon Dec 7, 2024
I can also confirm that for me the tests pass before #123244, and fail after it.
jieyouxu commentedon Dec 7, 2024
#123244 added some additional normalizations, FTR
Mark-Simulacrum commentedon Dec 7, 2024
We probably(?) need some extra normalization in the tests. The symbol in question (begin_panic) is probably found a bit differently by backtrace on this platform?
That said, we run these tests in CI for this platform, so it's not clear whether it's some local delta as well. Perhaps you have e.g. lld enabled or some other optimization setting that's not set in CI?
madsmtm commentedon Dec 8, 2024
I can reproduce it on my machine too (also using macOS 14.7.1), on both Aarch64 and x86_64 (using Rosetta), so that's at least weak evidence that it's not something environment specific.
Not sure what the underlying issue is yet though.
Zalathar commentedon Dec 26, 2024
I can make the failures go away by setting
rust.debuginfo-level = 1, and then make them appear again by settingrust.debuginfo-level = "line-tables-only", which is the compiler profile default.That helps to explain why it doesn't show up on CI.
Rollup merge of rust-lang#134781 - Zalathar:backtrace, r=SparrowLii,j…
Rollup merge of rust-lang#134781 - Zalathar:backtrace, r=SparrowLii,j…
Unrolled build for rust-lang#134781
Zalathar commentedon Dec 27, 2024
Fixed by adding more normalizations in #134781.
Rollup merge of rust-lang#134781 - Zalathar:backtrace, r=SparrowLii,j…