Skip to content

compiletest: error emitter pretty svg tests don't normalize color differences between Windows and Unixes #135270

Open

Description

@jieyouxu

Image
Image

This is the svg snapshots of the same test test/ui/error-emitter/multiline-removal-suggestion.rs (the former is the reference Unix-blessed snapshot, the latter is generated on Windows with //@ only-linux removed), but I believe this fails on Windows because the exact colors chosen are different. I believe this is because there are certain cmd.exe default bright colors which are very hard to read, so we actually pick different colors on purpose.

cc @estebank for FYI: I reasoned about the failure in #134664 incorrectly, I found out today after revisiting #132752, which is a different bug.

Activity

  1. added
    C-bugCategory: This is a bug.
    O-windowsOperating system: Windows
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jan 8, 2025
  2. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jan 8, 2025
  3. added
    A-diagnosticsArea: Messages for errors, warnings, and lints
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    A-compiletestArea: The compiletest test runner
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jan 8, 2025
  4. added
    D-diagnostic-infraDiagnostics: Issues that affect all diagnostics, or relate to the diagnostic machinery itself.
    on Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-diagnosticsArea: Messages for errors, warnings, and lintsA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.D-diagnostic-infraDiagnostics: Issues that affect all diagnostics, or relate to the diagnostic machinery itself.O-windowsOperating system: WindowsT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions