wasm-validator errors when trying to compile rust-brotli to wasm32 #42518

Activity

1. malbarbo commented on Jun 9, 2017

   

   malbarbo

   on Jun 9, 2017

   Contributor

   More actions

   Some libc definitions are wrong for emscripten target, see rust-lang/libc#610.

   Here is a small example that fails to compile:

   use std::fs::File;
   use std::io::{Seek, SeekFrom};
   
   fn main() {
       let mut f = File::open("x.txt").unwrap();
       f.set_len(5).unwrap();
       f.seek(SeekFrom::Start(2)).unwrap();
   }

   It works for asmjs (I think because there is no validation), but fails for wasm32. The error is:

   [wasm-validator error in function $__ZN3std2fs4File7set_len17h668c1fb11d26e7feE] 2 != 1: call param types must match, on
   [i32] (call $_ftruncate
    [i32] (get_local $3)
    [i64] (get_local $2)
   )
   [wasm-validator error in function $__ZN47__LT_std__fs__File_u20_as_u20_std__io__Seek_GT_4seek17h53361e7da9834951E] 2 != 1: call param types must match, on
   [i32] (call $_lseek
    [i32] (get_local $5
    [i64] (get_local $22)
    [i32] (get_local $24)
   )
   

   The problem is that off_t should be i32 but was i64. Although the libc patch are tested against asmjs, I think that it will work for wasm32.

   After the libc PR get merged, it is necessary to update libc in rust. Well, I hope this assertions are correct, after all, the tests are green.

   👍React with 👍3Reacted by Lilian Anatolie Moraru, Sergey Rubanov and Sergei Shulepov
2. sanxiyn

   added

   O-wasmTarget: WASM (WebAssembly), http://webassembly.org/Target: WASM (WebAssembly), http://webassembly.org/

   on Jun 9, 2017
3. Mark-Simulacrum

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   on Jul 27, 2017
4. lilianmoraru commented on Sep 6, 2017

   

   lilianmoraru

   on Sep 6, 2017

   Author

   More actions

   Still doesn't compile on nightly :(
   Even with --features no-stdlib
5. Enselic commented on Sep 21, 2023

   

   Enselic

   on Sep 21, 2023

   Member

   More actions

   Triage: Is this still a problem 6 years later? (If it would be easy to check I would check myself, but doesn't seem easy to check.)
6. Enselic commented on Apr 18, 2024

   

   Enselic

   on Apr 18, 2024

   Member

   More actions

   Triage: Assuming not a problem any longer. Closing.
7. Enselic

   closed this as not plannedon Apr 18, 2024