Skip to content

Tracking issue for RFC 2397, "#[do_not_recommend]" #51992

Description

@Centril

This is a tracking issue for the RFC "Introduce #[do_not_recommend] to control errors for trait impls" (rust-lang/rfcs#2397).

Steps:

Unresolved questions:

  • What other names could we go with besides #[do_not_recommend]? (See RFC for some suggestions)

implementation history:

Activity

  1. added
    A-diagnosticsArea: Messages for errors, warnings, and lints
    B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.
    T-langRelevant to the language team
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Jul 2, 2018
  2. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jul 2, 2018
  3. nagisa commented on Jul 2, 2018

    @nagisa
    Member

    Minor question. Presuming we implement this, and later change diagnostics in ways that make this attribute unnecessary/harmful, what would the plan of action be then?

    Does this attribute essentially encode some particular format of these specific errors?

  4. Centril commented on Jul 2, 2018

    @Centril
    ContributorAuthor

    @nagisa in that hypothetical situation, deprecate the attribute perhaps?

  5. scottmcm commented on May 11, 2022

    @scottmcm
    Member

    This came up in T-lang's backlog bonanza today. With no progress on this for years, it's not clear to us that this is still the right way forward here.

    @estebank, do you have any thoughts on this one? Perhaps it would be better rolled into the idea you brought up in https://internals.rust-lang.org/t/stable-diagnostic-affecting-attribute-with-unstable-api/16368?u=scottmcm?

  6. added 2 commits that reference this issue on Jan 11, 2023
  7. 34 remaining items

  8. added 7 commits that reference this issue on Feb 20, 2025
    270ee92
    dadd8aa
    70eb45f
    d2a2444
    cf6434b
    23302ae
    009f40d
  9. added 8 commits that reference this issue on Mar 3, 2025
    f9c0b8e
    afe027b
    b66d166
    03af162
    144dea3
    a6245a1
    a49074f
    589340b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsA-trait-systemArea: Trait systemB-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCS-tracking-unimplementedStatus: The feature has not been implemented.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-langRelevant to the language teamWG-diagnosticsWorking group: Diagnostics

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions