Repository navigation
Tracking issue for RFC 2397, "#[do_not_recommend]" #51992
Copy link
Copy link
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsA-trait-systemArea: Trait systemArea: Trait systemB-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCS-tracking-unimplementedStatus: The feature has not been implemented.Status: The feature has not been implemented.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-langRelevant to the language teamRelevant to the language teamWG-diagnosticsWorking group: DiagnosticsWorking group: Diagnostics
Description
Activity
- addedA-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsA-trait-systemArea: Trait systemArea: Trait systemB-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.T-langRelevant to the language teamRelevant to the language teamC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFC
on Jul 2, 2018 - addedT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
on Jul 2, 2018 Minor question. Presuming we implement this, and later change diagnostics in ways that make this attribute unnecessary/harmful, what would the plan of action be then?
Does this attribute essentially encode some particular format of these specific errors?
Reacted by varkor@nagisa in that hypothetical situation, deprecate the attribute perhaps?
- addedS-tracking-unimplementedStatus: The feature has not been implemented.Status: The feature has not been implemented.
on May 11, 2022 This came up in T-lang's backlog bonanza today. With no progress on this for years, it's not clear to us that this is still the right way forward here.
@estebank, do you have any thoughts on this one? Perhaps it would be better rolled into the idea you brought up in https://internals.rust-lang.org/t/stable-diagnostic-affecting-attribute-with-unstable-api/16368?u=scottmcm?
- addedWG-diagnosticsWorking group: DiagnosticsWorking group: Diagnosticsand removed
on Jun 24, 2022 34 remaining items
- added 7 commits that reference this issue
on Feb 20, 2025 - added 8 commits that reference this issue
on Mar 3, 2025
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsA-trait-systemArea: Trait systemArea: Trait systemB-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCS-tracking-unimplementedStatus: The feature has not been implemented.Status: The feature has not been implemented.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-langRelevant to the language teamRelevant to the language teamWG-diagnosticsWorking group: DiagnosticsWorking group: Diagnostics
This is a tracking issue for the RFC "Introduce
#[do_not_recommend]to control errors for trait impls" (rust-lang/rfcs#2397).Steps:
Unresolved questions:
#[do_not_recommend]? (See RFC for some suggestions)implementation history:
#[do_not_recommend]attribute if present #124708#[diagnostic::do_not_recommend]support #125717#[do_not_recommend]to the#[diagnostic]namespace #125326#[diagnostic::do_not_recommend]to supress trait impls in suggestions as well #127598