Skip to content

Tracking Issue for feature future_poll_fn #72302

Closed
#99306
Closed
Tracking Issue for feature future_poll_fn#72302
#99306
Labels
A-async-awaitArea: Async & AwaitAsyncAwait-TriagedAsync-await issues that have been triaged during a working group meeting.B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCI-libs-radarLibs issues that are tracked on the team's radar.T-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

Description

@yoshuawuyts
yoshuawuyts
opened on May 17, 2020

The feature gate for the issue is #![feature(future_poll_fn)].

Steps

Unresolved Questions

  • Should this be named future::from_fn instead?

Implementation history

Activity

  1. yoshuawuyts
    added
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on May 17, 2020
  2. jonas-schievink
    added
    A-async-awaitArea: Async & Await
    B-unstableBlocker: Implemented in the nightly compiler and unstable.
    T-libs-api[DEPRECATED; DO NOT USE]
    on May 17, 2020
  3. tmandry
    added
    AsyncAwait-TriagedAsync-await issues that have been triaged during a working group meeting.
    on May 19, 2020
  4. KodrAus
    added
    I-libs-radarLibs issues that are tracked on the team's radar.
    on Jul 29, 2020

  5. joshtriplett commented on Jun 20, 2022

    @joshtriplett
    joshtriplett
    on Jun 20, 2022
    Member

    This exists in futures-lite, and people use it. It seems worth having available in the standard library.

    The naming discussion doesn't seem likely to change, and all else being equal there's a history for the name poll_fn.

    Shall we stabilize this?

    @rfcbot merge

  6. rfcbot commented on Jun 20, 2022

    @rfcbot
    rfcbot
    on Jun 20, 2022

    Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  7. rfcbot
    added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
    on Jun 20, 2022
  8. rfcbot
    added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Jun 29, 2022

  9. rfcbot commented on Jun 29, 2022

    @rfcbot
    rfcbot
    on Jun 29, 2022

    🔔 This is now entering its final comment period, as per the review above. 🔔

  10. rfcbot
    removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Jun 29, 2022
  11. rfcbot
    added
    finished-final-comment-periodThe final comment period is finished for this PR / Issue.
    and removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Jul 9, 2022

  12. rfcbot commented on Jul 9, 2022

    @rfcbot
    rfcbot
    on Jul 9, 2022

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    This will be merged soon.

  13. rfcbot
    added
    to-announceAnnounce this issue on triage meeting
    on Jul 9, 2022
  14. JohnTitor
    added a commit that references this issue on Jul 17, 2022

    Rollup merge of rust-lang#99306 - JohnTitor:stabilize-future-poll-fn,…

    5052769
  15. bors
    closed this as completedin 5052769on Jul 17, 2022
  16. apiraino
    removed
    to-announceAnnounce this issue on triage meeting
    on Sep 8, 2022
  17. workingjubilee
    added a commit that references this issue on Sep 15, 2022

    Rollup merge of #99306 - JohnTitor:stabilize-future-poll-fn, r=joshtr…

    8c18a11

  18. RalfJung commented on Oct 6, 2022

    @RalfJung
    RalfJung
    on Oct 6, 2022
    Member

    There are some soundness issues with poll_fn (not strictly speaking a soundness bug, but we might still want to do a breaking change now before there are too many people relying on this): the fact that PollFn<F> is always Unpin is a problem. It should require F: Unpin for that.

    See IRLO for details, in particular this miscompilation bug.

  19. RalfJung commented on Oct 6, 2022

    @RalfJung
    RalfJung
    on Oct 6, 2022
    Member

    I am proposing to change the Unpin impl in #102737.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-async-awaitArea: Async & AwaitAsyncAwait-TriagedAsync-await issues that have been triaged during a working group meeting.B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCI-libs-radarLibs issues that are tracked on the team's radar.T-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions