Skip to content

x.py test specific directory requires platform specific path separator #79334

Closed

Description

@Havvy

On Windows, I tried this code:

python x.py test src/test/ui/expr/compound-assignment/eval-order.rs --pass run

I expected to execute the file and give back a test result. Instead, it found zero results.

After an hour of flailing, I tired:

python x.py test src/test/ui\expr\compound-assignment\eval-order.rs --pass run

And to my (pleasant) surprised, it found the file.

Ideally, it shouldn't matter which path separator is used at any point.

Activity

  1. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    C-bugCategory: This is a bug.
    on Nov 23, 2020
  2. added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rust
    on Nov 23, 2020
  3. jyn514 commented on Aug 8, 2022

    @jyn514
    Member

    This is an issue with libtest - compiletest passes in expr/compound-assignment/eval-order.rs as the filter, which libtest counts as filtering out expr\compound-assignment\eval-order.rs too.

    I think the workaround is to manually turn forward slashes into backslashes in impl Step for test::Compiletest when running on windows.

  4. added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
    O-windowsOperating system: Windows
    on Aug 8, 2022
  5. czzrr commented on Aug 9, 2022

    @czzrr
    Contributor

    @rustbot claim

  6. added 2 commits that reference this issue on Aug 23, 2022
  7. added a commit that references this issue on Aug 24, 2022
  8. added a commit that references this issue on Aug 27, 2022
  9. added a commit that references this issue on Aug 27, 2022
  10. jyn514 commented on Sep 19, 2022

    @jyn514
    Member

    Looks like this was fixed in #100811 :) thanks @czzrr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.O-windowsOperating system: WindowsT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions