x.py ignores config.toml's debug-assertions-std for unit tests #79481

Activity

1. ssomers

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   on Nov 27, 2020
2. jyn514

   added

   T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

   T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.

   on Nov 28, 2020
3. jyn514 commented on Oct 11, 2021

   

   jyn514

   on Oct 11, 2021

   Member

   More actions

   @ssomers I can't reproduce. I added this assert:

   diff --git a/library/core/tests/iter/traits/iterator.rs b/library/core/tests/iter/traits/iterator.rs
   index 422e389e380..77e1effc764 100644
   --- a/library/core/tests/iter/traits/iterator.rs
   +++ b/library/core/tests/iter/traits/iterator.rs
   @@ -26,6 +26,7 @@ fn cmp(&self, other: &Self) -> core::cmp::Ordering {
    
    #[test]
    fn test_lt() {
   +    debug_assert!(false);
        let empty: [isize; 0] = [];
        let xs = [1, 2, 3];
        let ys = [1, 2, 0];
   

   and set debug = false and debug-assertions-std = true, and got an assertion failure as expected.

   Are you expecting assertions to run in coretests maybe?
4. ssomers commented on Oct 11, 2021

   

   ssomers

   on Oct 11, 2021

   Last edited by ssomers

   ContributorAuthor

   More actions

   Not exactly sure what I was doing back then, nor what you mean with running in coretests. Today, I'd expect, for instance when
   adding to library/alloc/src/collections/btree/node/tests.rs:

   #[test]
   fn test_assert() {
       assert!(false)
   }
   
   #[test]
   fn test_debug_assert() {
       debug_assert!(false)
   }

   and running python x.py test library/alloc --no-doc, that both new test cases fail. What I'm seeing is that the debug_assert doesn't even fail when enabling debug, debug-assertions and debug-assertions-std in config.toml.
5. jyn514

   changed the title [-]x.py ignores config.toml's debug-assertions-std[/-] [+]x.py ignores config.toml's debug-assertions-std for unit tests[/+] on Nov 25, 2021
6. jyn514 commented on Nov 26, 2021

   

   jyn514

   on Nov 26, 2021

   Member

   More actions

   @ssomers I'm still not able to replicate this. I ran x test library/alloc --stage 0 --test-args debug_assert with your test case added and the test failed appropriately:

   Testing alloc stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
      Compiling getrandom v0.1.14
      Compiling ppv-lite86 v0.2.8
      Compiling rand_core v0.5.1
      Compiling rand_chacha v0.2.2
      Compiling rand_xorshift v0.2.0
      Compiling rand v0.7.3
      Compiling alloc v0.0.0 (/home/joshua/src/rust/rust/library/alloc)
       Finished release [optimized + debuginfo] target(s) in 1m 15s
        Running unittests (build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/alloc-cd5eecf891e8cfac)
   
   running 1 test
   F
   failures:
   
   ---- collections::btree::node::tests::test_debug_assert stdout ----
   thread 'collections::btree::node::tests::test_debug_assert' panicked at 'assertion failed: false', library/alloc/src/collections/btree/node/tests.rs:106:5
   
7. ssomers commented on Nov 27, 2021

   

   ssomers

   on Nov 27, 2021

   ContributorAuthor

   More actions

   Well, I can still replicate it… on the master at the time. I located the fix at auto merge #90042 (25 October).

   And it's really flawless now. The debug assertions detonate if debug or debug-assertions-std is true, or both, and you don't need to clean anything before building to see it.

   👍React with 👍1Reacted by jyn
8. ssomers

   closed this as completedon Nov 27, 2021