You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rustdoc new crate filter location visually unpolished #93240
The sans serif vs. serif is clearly a bug. That’s looking terrible.
The location being in a place that moves horizontally is suboptimal; changing that would be an enhancement. The font size is ridiculously high (because it’s part of a “title”, I guess?). I like the thing no longer being inside of the search bar like it used to be, so I’m not suggesting any reverts, just more polishing work. Maybe this option could be placed e.g. still roughly next to the “Results for …” heading, but right-justified so it doesn’t move around when I change my search term, and also in a normal / more reasonable size. E.g. saying something like “search in [all crates]”.
By the way, something not indicated in the picture that I just noticed: if it says “… in [All crates]”, I don’t think the “All” should be capitalized anymore.
The question of whether or not it’s necessary for rustdoc to parrot my search term at all is one I don’t care all that much about. If there’s any benefit to keeping it, sure, keep it; I don’t really care.
(Minor note, looking back at my image, the arrows are a bit short. The text about font size is in-fact referring to the font size of the dropdown list, nothing else.)
Should this be a dropdown at all? It seems like something that could be a search operator, at least if we had some sort of auto-suggest. E.g. type in:rustc_ in the search bar and it'll offer available creates.
Should this be a dropdown at all? It seems like something that could be a search operator, at least if we had some sort of auto-suggest. E.g. type in:rustc_ in the search bar and it'll offer available creates.
Yeah, I suggested this a couple weeks ago. I think the idea is to do it once we also have an "advanced search builder".
Activity
the8472 commentedon Jan 23, 2022
Should this be a dropdown at all? It seems like something that could be a search operator, at least if we had some sort of auto-suggest. E.g. type
in:rustc_in the search bar and it'll offer available creates.camelid commentedon Jan 25, 2022
cc @jsha @GuillaumeGomez
camelid commentedon Jan 25, 2022
Yeah, I suggested this a couple weeks ago. I think the idea is to do it once we also have an "advanced search builder".
GuillaumeGomez commentedon Jan 25, 2022
Yes, we still need to discuss things. We will do that once everyone is available. ;)
GuillaumeGomez commentedon Oct 27, 2022
I think this issue was fixed by #100374. Don't hesitate to reopen it if I'm mistaken.