Skip to content

Rustdoc new crate filter location visually unpolished #93240

Closed

Description

@steffahn

I took a few notes while looking at nightly rustc docs:

Screenshot_20220123_165956

@rustbot label T-rustdoc, C-bug, C-enhancement, A-rustdoc-ui

The sans serif vs. serif is clearly a bug. That’s looking terrible.

The location being in a place that moves horizontally is suboptimal; changing that would be an enhancement. The font size is ridiculously high (because it’s part of a “title”, I guess?). I like the thing no longer being inside of the search bar like it used to be, so I’m not suggesting any reverts, just more polishing work. Maybe this option could be placed e.g. still roughly next to the “Results for …” heading, but right-justified so it doesn’t move around when I change my search term, and also in a normal / more reasonable size. E.g. saying something like “search in [all crates]”.

By the way, something not indicated in the picture that I just noticed: if it says “… in [All crates]”, I don’t think the “All” should be capitalized anymore.

The question of whether or not it’s necessary for rustdoc to parrot my search term at all is one I don’t care all that much about. If there’s any benefit to keeping it, sure, keep it; I don’t really care.


(Minor note, looking back at my image, the arrows are a bit short. The text about font size is in-fact referring to the font size of the dropdown list, nothing else.)

Activity

  1. added
    A-rustdoc-uiArea: Rustdoc UI (generated HTML)
    C-bugCategory: This is a bug.
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    on Jan 23, 2022
  2. the8472 commented on Jan 23, 2022

    @the8472
    Member

    Should this be a dropdown at all? It seems like something that could be a search operator, at least if we had some sort of auto-suggest. E.g. type in:rustc_ in the search bar and it'll offer available creates.

  3. camelid commented on Jan 25, 2022

    @camelid
    Member
  4. camelid commented on Jan 25, 2022

    @camelid
    Member

    Should this be a dropdown at all? It seems like something that could be a search operator, at least if we had some sort of auto-suggest. E.g. type in:rustc_ in the search bar and it'll offer available creates.

    Yeah, I suggested this a couple weeks ago. I think the idea is to do it once we also have an "advanced search builder".

  5. GuillaumeGomez commented on Jan 25, 2022

    @GuillaumeGomez
    Member

    Yes, we still need to discuss things. We will do that once everyone is available. ;)

  6. GuillaumeGomez commented on Oct 27, 2022

    @GuillaumeGomez
    Member

    I think this issue was fixed by #100374. Don't hesitate to reopen it if I'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions