Skip to content

Check for stale files in src/test/mir-opt #97564

Closed
#103781
Closed
Check for stale files in src/test/mir-opt#97564
#103781
Assignees
JakobDegen
Labels
A-mir-optArea: MIR optimizationsA-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.

Description

@JakobDegen
JakobDegen
opened on May 30, 2022

This folder currently contains a number of inst_combine_deref*.diff files that are completely unused - the associated .rs file that generated them was removed all the way back in #81101 . In addition to deleting these files, we should also add a check to compiletest that makes sure that the mir-opt folder contains no files that do not belong to any tests (with the exception of the readme).

@rustbot label +C-enhancement +A-test-suite +A-mir-opt

Activity

  1. JakobDegen commented on May 30, 2022

    @JakobDegen
    JakobDegen
    on May 30, 2022 · Hidden as outdated
    Author

  2. JakobDegen commented on May 30, 2022

    @JakobDegen
    JakobDegen
    on May 30, 2022 · Hidden as outdated
    Author

  3. JakobDegen commented on May 30, 2022

    @JakobDegen
    JakobDegen
    on May 30, 2022 · Hidden as outdated
    Author

  4. JakobDegen commented on May 30, 2022

    @JakobDegen
    JakobDegen
    on May 30, 2022
    ContributorAuthor

    I thought I was getting the command wrong, maybe the bot is down?

  5. compiler-errors
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    A-mir-optArea: MIR optimizations
    on May 30, 2022

  6. compiler-errors commented on May 30, 2022

    @compiler-errors
    compiler-errors
    on May 30, 2022
    Contributor

    compiler-errorsbot added them for you because rustbot is on holiday 😝

  7. JakobDegen commented on May 30, 2022

    @JakobDegen
    JakobDegen
    on May 30, 2022
    ContributorAuthor

    🤣 ❤️ thank you!

  8. ehuss commented on May 31, 2022

    @ehuss
    ehuss
    on May 31, 2022
    Contributor

    See also #77498.

  9. Dylan-DPC
    added a commit that references this issue on May 31, 2022

    Rollup merge of rust-lang#97570 - JakobDegen:dse-test, r=tmiasko

    ca4a9ac
  10. bors
    added a commit that references this issue on May 31, 2022

    Auto merge of rust-lang#97570 - JakobDegen:dse-test, r=tmiasko

    0595ea1
  11. Dylan-DPC
    added a commit that references this issue on Sep 7, 2022

    Rollup merge of rust-lang#101435 - JakobDegen:bitwidth-tests, r=wesle…

    d81aa36
  12. matthiaskrgr
    added a commit that references this issue on Sep 7, 2022

    Rollup merge of rust-lang#101435 - JakobDegen:bitwidth-tests, r=wesle…

    1d65e96

  13. JakobDegen commented on Oct 27, 2022

    @JakobDegen
    JakobDegen
    on Oct 27, 2022
    ContributorAuthor

    @rustbot claim

    This has bitten me once too many times now in #101428 , gonna fix it

  14. rustbot
    assigned
    JakobDegen
    on Oct 27, 2022
  15. Manishearth
    added a commit that references this issue on Nov 2, 2022

    Rollup merge of rust-lang#103781 - JakobDegen:mir-opt-tidy, r=jyn514

    e2a6d28
  16. bors
    closed this as completedin e2a6d28on Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-mir-optArea: MIR optimizationsA-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions